Feat/unify env file resolution#376
Merged
kilodesodiq-arch merged 5 commits intoJul 17, 2026
Merged
Conversation
Contributor
|
Awesome work on this! Thanks for the contribution 🚀 Merging now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #255
Summary
Unifies environment file resolution and loading logic between
main.tsandapp.module.tsto eliminate drift in.envlookup paths.Introduced a central helper
loadEnv()insrc/common/utils/env-loader.tsto coordinate search candidates deterministically. The helper enforces that.envfile values take precedence over OS environment variables (dotenvalways wins over the OS env).Testing
A new test suite was created under
src/common/utils/__tests__/env-loader.spec.tsasserting that:loadEnv()calls (themain.tspath) and NestJS module initialization (theapp.module.tspath) agree on the final environment state.bun test app/backend/src/common/utils/__tests__/env-loader.spec.tsScreenshots
N/A (Backend changes only)
Checklist