Repository navigation
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
==========================================
+ Coverage 91.60% 91.61% +0.01%
==========================================
Files 72 72
Lines 2560 2564 +4
==========================================
+ Hits 2345 2349 +4
Misses 215 215 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is partially breaking
Fix
build_scaling_arraymode in IC generators:GaussianRandomFieldandRandomTruncatedFourierSeriesusedmode="coef_extraction"when pre-scaling Fourier coefficients beforeifft. This mode doubles along every axis for non-zero, non-Nyquist modes, butirfftnonly restores conjugates along the right-most axis. The result is that physical amplitudes on non-right-most axes are halved in 2D+. Changed tomode="reconstruction", which only doubles along the right-most axis. No behavior change in 1D (the two modes are identical when there is only one axis).Fix inverted
std_onevalidation: The conditionoffset_range == (0.0, 0.0) and std_oneincorrectly rejected zero offset withstd_one=True(valid) and allowed non-zero offset withstd_one=True(invalid). Flipped to!=.Closes #34