CATROID-1658 Fix failing test ActionBarUndoSpinnerTest.testUndoSpinnerAction#5215
Open
hannesweilharter wants to merge 2 commits into
Open
CATROID-1658 Fix failing test ActionBarUndoSpinnerTest.testUndoSpinnerAction#5215hannesweilharter wants to merge 2 commits into
ActionBarUndoSpinnerTest.testUndoSpinnerAction#5215hannesweilharter wants to merge 2 commits into
Conversation
Member
|
@hannesweilharter IMO, could you please refactor this test file to Kotlin as well? Since we are currently refactoring many files, and you are already working on fixing the failing tests, I think it would be good if we also migrated this one during the process. |
c8e1171 to
5ddd825
Compare
|
harshsomankar123-tech
approved these changes
May 17, 2026
Member
harshsomankar123-tech
left a comment
There was a problem hiding this comment.
@hannesweilharter Thanks! LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Instead of mocking the File class, real sound and look files are generated. This seems to fix the failing testcase.
Additionally, the file was refactored to Kotlin
https://catrobat.atlassian.net/browse/CATROID-1658
Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.