Skip to content

CATROID-376: Integrate LeakCanary for Memory Leak Detection #5184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harshsomankar123-tech wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

CATROID-376: Integrate LeakCanary for Memory Leak Detection #5184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions catroid/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,6 +510,9 @@ dependencies {

// Room Test helpers
testImplementation("androidx.room:room-testing:$room_version")

// LeakCanary - Memory leak detection (debug builds only)
debugImplementation 'com.squareup.leakcanary:leakcanary-android:2.14'
}

static def getGitCommitInfo() {
Expand Down
5 changes: 3 additions & 2 deletions catroid/src/main/java/org/catrobat/catroid/web/CatrobatServerCalls.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ import okhttp3.ConnectionSpec
import okhttp3.Interceptor
import okhttp3.OkHttpClient
import okhttp3.Request
import okio.Okio
import okio.buffer
import okio.sink
import org.catrobat.catroid.common.Constants
import org.catrobat.catroid.web.ServerAuthenticationConstants.CHECK_EMAIL_AVAILABLE_URL
import org.catrobat.catroid.web.ServerAuthenticationConstants.CHECK_GOOGLE_TOKEN_URL
Expand Down Expand Up @@ -248,7 +249,7 @@ class CatrobatServerCalls(private val okHttpClient: OkHttpClient = CatrobatWebCl
try {
val response = httpClient.newCall(request).execute()
if (response.isSuccessful) {
val bufferedSink = Okio.buffer(Okio.sink(destination))
val bufferedSink = destination.sink().buffer()
response.body()?.let { bufferedSink.writeAll(it.source()) }
bufferedSink.close()
successCallback.onSuccess()
Expand Down
Loading