Adds default currency feature #2972
Conversation
TheLastProject
left a comment
TheLastProject
left a comment
There was a problem hiding this comment.
Didn't do a full depth review but I see multiple severe bugs. Please make sure to test your implementation well.
| private void formatBalanceCurrencyField(Currency balanceType) { | ||
| if (balanceType == null) { | ||
| balanceCurrencyField.setText(getString(R.string.points)); | ||
| Currency defaultCurrency = new Settings(getApplicationContext()).getCurrency(); |
There was a problem hiding this comment.
Won't this keep changing Points to the "Default currency" every time someone opens the edit view, thus changing it away from Points? Making it impossible to keep using points unless you keep setting it back?
Seems to me the only sensible moment is to only ever set it once for a new card.
There was a problem hiding this comment.
Completly agree. I refactored the code to identify new cards creation, removing the ambiguity related to "currency == null", separating new cards from points option.
| } | ||
|
|
||
| public Currency getCurrency() { | ||
| String value = getString(R.string.settings_key_default_currency, "Points"); |
There was a problem hiding this comment.
You cannot use the string "Points" as this is translatable, will break for anything but English by default.
- Correctly assigned symbols to currency codes for respectively entries and entrieValues - Removed hardcoded string "Points" - Only select default currency at the creation of a new card (when its required field is empty)
2 participants
implements #2886