CP-15418 - Fix completed Docuseal documents failing to open when the file name has spaces - #87
Merged
Merged
Conversation
…file name has spaces What Completed Docuseal documents now open correctly even when the original file name contains spaces, parentheses, or other special characters. If a secure document link still cannot be generated, users now see a friendly error message instead of a raw "Access denied" page, and the failure is reported to error tracking. Why Customers could not view completed employee forms (for example "F-O-C-880 CLIENT CONFIDENTIALITY.docx (1)") from the employee Documents tab. The signed link was built from the un-encoded file name, so the browser's version of the URL no longer matched the signature and access was denied. The files were never lost; the link was just invalid. How to test Open an employee's Documents tab and click a completed Docuseal form whose file name contains spaces or parentheses. The PDF should open. Also confirm a document with a plain file name (no spaces) still opens as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Completed Docuseal documents now open correctly even when the original file name contains spaces, parentheses, or other special characters. If a secure document link still cannot be generated, users now see a friendly error message instead of a raw "Access denied" page, and the failure is reported to error tracking.
Why
Customers could not view completed employee forms (for example "F-O-C-880 CLIENT CONFIDENTIALITY.docx (1)") from the employee Documents tab. The signed link was built from the un-encoded file name, so the browser's version of the URL no longer matched the signature and access was denied. The files were never lost; the link was just invalid.
How to test
Open an employee's Documents tab and click a completed Docuseal form whose file name contains spaces or parentheses. The PDF should open. Also confirm a document with a plain file name (no spaces) still opens as before.