fix(frontend): plan page dark-mode loader and checkout popup - #2900
Conversation
Inherit spinner color for dark-mode plan buttons and open Stripe checkout via a confirm link so browsers do not block the tab after async session creation. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 28 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
📝 WalkthroughWalkthroughWeb Stripe checkout now uses a confirmation flow across web platforms. Blocked popups show a manual checkout link. Dialog handling and E2E coverage were updated for the new-tab flow. ChangesStripe checkout flow
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Plans
participant openBlank
participant Browser
participant DialogV2
Plans->>openBlank: Open Stripe checkout URL
openBlank->>Browser: Call window.open
Browser-->>openBlank: Return popup result
openBlank->>DialogV2: Show manual link when blocked
DialogV2->>Browser: Open checkout link in a new tab
Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Comment |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_7fb8b852-c486-4fbd-9945-848987c09f8d) |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Merging this PR will not alter performance
Comparing 
Footnotes
|
Propagate iOS action-sheet cancel from openBlank and align the subscription checkout E2E with the confirm-link web flow. Co-authored-by: Cursor <cursoragent@cursor.com>
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_aae79b41-24a0-411a-8712-24009d1719b1) |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/services/stripe.ts`:
- Around line 62-64: Update the popup-opening flow around the opened result from
globalThis.open to set opened.opener to null before returning true; preserve the
existing null-return fallback unchanged.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 0fe8e1e1-4d43-4f9d-9e1b-c246893fda06
📒 Files selected for processing (5)
messages/en.jsonplaywright/e2e/subscription-checkout.spec.tssrc/components/DialogV2.vuesrc/pages/settings/organization/Plans.vuesrc/services/stripe.ts
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
Cap-go/capacitor-updater(manual)
There was a problem hiding this comment.
All reported issues were addressed across 2 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Local screenshots from the worktree app showing the subscribe button spinner visible on the dark-mode white button. Co-authored-by: Cursor <cursoragent@cursor.com>
Visual verification (AI generated)Local dark-mode screenshot from this branch (
|
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_267f4f97-792c-4819-9297-6ed1edf7dc0c) |
Null window.opener after a successful openBlank, and assert Stripe checkout via the Confirm dialog's native target=_blank popup. Co-authored-by: Cursor <cursoragent@cursor.com>
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_c73cace6-8233-4e46-907a-1ac982667674) |
|
1 participant
Summary (AI generated)
_blanklink after Stripe session creation, avoiding popup blockerstarget="_blank"anchors open natively instead ofpreventDefault+window.openopenBlankfalls back to a confirm link when the browser blocks the popupVisual verification (AI generated)
Local dark-mode run on this worktree (
ENV=localVite + worktree Supabase). Clicked Upgrade with checkout delayed so the loader stays visible on the white dark-mode button.Motivation (AI generated)
Dark mode made the subscribe loading spinner invisible (
text-whiteondark:bg-white). Checkout also opened withwindow.openafter an async API call, which browsers often block.Business Impact (AI generated)
Users can see checkout loading in dark mode and complete plan upgrades without a blocked Stripe tab.
Test Plan (AI generated)
/settings/organization/plansin dark mode and click a plan CTA — spinner is visible on black and white buttonswindow.open, confirm the fallback dialog can open the URLGenerated with AI
Made with Cursor
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by CodeRabbit
New Features
Bug Fixes