Make mkylib reusable and install it#24
Open
jktjkt wants to merge 3 commits intoCZ-NIC:masterfrom
Open
Conversation
Those who obtained yangson via PIP do not have access to tools/, so let's make this binary available as a command.
This means no direct print() or sys.exit() or sys.argv access, so let's wrap this into something which preserves the required behavior of setuptools' `console_scripts`, yet makes it possoble for Python calles to simply import this submodule and use it directly from code.
Member
|
Ahoj @jktjkt, I am sorry for responding so late. Regarding your PR, I am somewhat concerned that by making it an “official” script we could mislead users into thinking that it solves the problem of creating a YANG library file completely. It is usually not the case – modules from other directories often have to be added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm looking at using yangson with @Telecominfraproject's oopt-gnpy because yangson looks like something that can validate JSON files against a YANG schema. Thanks for the tool!
One thing which made the workflow more complex for me was the fact that
mkylibwas not installed viapip install yangson. This patch therefore makes it available asyangson-mkylib. While at it, I also adjusted the wrapping a bit so that the code is usable from Python without directsys.exitcalls,print(), etc.: