Positive decomposition#980
Merged
Merged
Conversation
…rting MDD natively)
Collaborator
|
reviewed in #981 |
tias
reviewed
Jun 1, 2026
tias
left a comment
Collaborator
There was a problem hiding this comment.
neat.
One change needed I think.
Are we sure the 'constraining','defining' is valid for the -> of MDD? That was an open question previously; is there a way to add a test for that?
… positive_decomp
Collaborator
Author
The constraining & defining constraints for positive decomp do seem right, based on my intuition and also on the tests |
Collaborator
|
OK great, it also makes sense to me but good to see it tested. I rewrote the 'if' part slighly to have clearer non-overlapping cases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building on #924 and #929, this is a first implementation of the separate positive decomposition for global constraints.
For now: