Skip to content

Positive decomposition#980

Merged
IgnaceBleukx merged 35 commits into
masterfrom
positive_decomp
Jun 1, 2026
Merged

Positive decomposition#980
IgnaceBleukx merged 35 commits into
masterfrom
positive_decomp

Conversation

@WoutPiessens

Copy link
Copy Markdown
Collaborator

Building on #924 and #929, this is a first implementation of the separate positive decomposition for global constraints.
For now:

  • decompose_positive() is called if the global constraint c is top-level or positively reified (b => c). In case the global constraint is nested in any other way, it is decomposed as it was before.
  • Only the MDD global constraint supports a separate positive decomposition

WoutPiessens and others added 24 commits April 16, 2026 17:59
@tias

tias commented May 21, 2026

Copy link
Copy Markdown
Collaborator

reviewed in #981

@tias tias mentioned this pull request May 21, 2026
32 tasks
@IgnaceBleukx IgnaceBleukx marked this pull request as ready for review June 1, 2026 09:20

@tias tias left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat.

One change needed I think.

Are we sure the 'constraining','defining' is valid for the -> of MDD? That was an open question previously; is there a way to add a test for that?

Comment thread cpmpy/transformations/decompose_global.py
@WoutPiessens

Copy link
Copy Markdown
Collaborator Author

neat.

One change needed I think.

Are we sure the 'constraining','defining' is valid for the -> of MDD? That was an open question previously; is there a way to add a test for that?

The constraining & defining constraints for positive decomp do seem right, based on my intuition and also on the tests

@tias

tias commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

OK great, it also makes sense to me but good to see it tested.

I rewrote the 'if' part slighly to have clearer non-overlapping cases

@IgnaceBleukx IgnaceBleukx merged commit 219dc06 into master Jun 1, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants