Fix edge case in canonical_comparison#1014
Merged
Merged
Conversation
Collaborator
Author
|
Also small change to canonical comparison: it now expects a list of Expressions and returns one too. This saves us a shotgun call to toplevel_list. Needed to make some small tweaks to the callers, and pumpkin |
tias
approved these changes
Jun 11, 2026
tias
left a comment
tias
left a comment
Collaborator
There was a problem hiding this comment.
great, also to have this function now typed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some weird cases, the left hand side of a sum can contain only constants after previous transformations, which was not handled properly.
Fixes #620 and #827