UX review top 2 issues - #174
Merged
Merged
Conversation
1 task
Contributor
|
@terrywbrady These changes look good to me on Stage. Adding a screenshot regarding the alt text for the CoreTrustSeal logo: 
|
Contributor
|
@terrywbrady - From Andrew, one update is needed regarding the tooltips: The new tooltips work well and effectively use aria-describedby, but one small fix is needed: the spans containing the tooltips should be given an aria-hidden="true" attribute. This still allows them to be referenced by aria-describedby on the inputs but hides the elements themselves from the accessibility tree so that they are not encountered by the screen reader in the linear reading order. Without this, the page flow breaks entirely when using VoiceOver on the MacOS version of Firefox, and on other browsers the elements are read aloud again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routine gem updates