Update bootstrap v2 - #1047
Update bootstrap v2#1047
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the UI layer to be compatible with newer jQuery/Bootstrap behavior by replacing deprecated jQuery event APIs, updating Bootstrap collapse/modal/carousel markup/classes, and aligning related CSS. It also refreshes some vendored frontend dependencies and adjusts local test DB setup to collect static assets.
Changes:
- Replace deprecated jQuery event shorthands and
.bind()/.unbind()usage with.on()/.off()across templates and scripts. - Update Bootstrap-related markup & CSS (e.g.,
collapse in→collapse show, carousel item classes,data-bs-*attributes). - Update dev vendored JS (jQuery UI) and remove older compatibility libraries (e.g., jquery-migrate, jquery.details polyfill); run
collectstaticin test DB prep.
Reviewed changes
Copilot reviewed 29 out of 34 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| templates/search/index.html | Update collapse expanded class and focus handling for newer jQuery/Bootstrap behavior. |
| templates/search/_results.html | Replace deprecated jQuery event APIs; adjust form submission call style. |
| templates/search/_pagination.html | Update event wiring for pagination controls and form submission. |
| templates/search/_choose_cols.html | Update modal dismiss markup and jQuery click handler style. |
| templates/manage/index.html | Update focus/click handlers and collapse expanded class. |
| templates/manage/edit.html | Update change handlers to use .on() and adjust programmatic form submission. |
| templates/learn.html | Replace deprecated click shorthand with .on(). |
| templates/layouts/base.html | Replace deprecated click shorthand with .on() for analytics tracking. |
| templates/index.html | Replace deprecated change handler with .on(). |
| templates/includes/get_link.html | Replace deprecated click shorthand with .on(). |
| templates/includes/footer.html | Update carousel markup/attributes for newer Bootstrap expectations. |
| templates/includes/advanced_remainder.html | Update focus/mouseup/change handlers to .on(). |
| templates/dashboard/index.html | Replace deprecated event APIs; adjust submission calls. |
| templates/dashboard/_totalIdsByMonth.html | Replace deprecated event APIs; adjust submission calls. |
| templates/dashboard/_dashboard_js.html | Update pagination event handlers and submission calls. |
| templates/create/_datacite_resourceType.html | Replace deprecated submit click shorthand with .on(). |
| templates/admin/change_form.html | Replace deprecated click/focus shorthands with .on()/.trigger(). |
| templates/admin-old/usage.html | Replace deprecated event APIs; adjust submission calls. |
| templates/account/_proxyModal.html | Replace deprecated click shorthand with .on(). |
| static_src/stylesheets/main.css | Update CSS selectors for Bootstrap show state and carousel item class names. |
| static_src/javascripts/simple_create.js | Replace deprecated change handler and adjust submit invocation. |
| static_src/javascripts/message_box.js | Replace deprecated event APIs with .off().on() / .on(). |
| static_src/javascripts/jquery.formset.twobutton.js | Replace deprecated click shorthand with .on(). |
| static_src/javascripts/help_box_.js | Replace deprecated keyup shorthand with .on(). |
| static_src/javascripts/fix_target.js | Replace deprecated submit shorthand with .on('submit', ...). |
| static_src/javascripts/advanced_create.js | Replace deprecated event APIs; adjust submit invocation and trim logic. |
| prepare_test_db.sh | Collect static files during test DB preparation. |
| dev/legacy-scss/_footer.scss | Update carousel item selector naming to match template/CSS changes. |
| dev/js/vendor/jquery.details.min.js | Remove vendored details polyfill. |
| dev/js/vendor/jquery-ui.js | Update vendored jQuery UI version/content. |
| dev/js/vendor/jquery-migrate-3.4.0.js | Remove vendored jQuery Migrate library. |
| dev/js/main2.js | Replace deprecated click shorthands with .on(). |
| dev/index.html | Remove jquery-migrate from dev index includes. |
Files not reviewed (1)
- static_src/stylesheets/main.css: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: jsjiang <12803478+jsjiang@users.noreply.github.com>
Co-authored-by: jsjiang <12803478+jsjiang@users.noreply.github.com>
sfisher
left a comment
There was a problem hiding this comment.
It's great that it updated this stuff and seems like lots of slight changes for how to trigger events with the newer api. Works well for me.
@sfisher Hi Scott,
All are JQuery and Bootstrap version related changes fixed using Copilot. Tag
v3.3.37_rc2is on ezid-stg. Functional and basic UI tests look good. Please review and test.Thank you
Jing