Conversation
| } | ||
|
|
||
| selectEventTypeInvestigation() { | ||
| // eslint-disable-next-line cypress/no-unnecessary-waiting |
There was a problem hiding this comment.
started to fix these no-unnecessary-waiting ones but realized there were a lot...
fixing these would require some effort to test to see if they are actually needed or we can use an alternative... so leaving as folks clean up other tests...
| Cypress.$(elt).mouseover(() => Cypress.$(elt).addClass("pageElementHover")) | ||
| .mouseout(() => Cypress.$(elt).removeClass("pageElementHover")); | ||
| } | ||
| cy.get('body').then(() => { |
There was a problem hiding this comment.
this test is not being actually run -- commented out for now until we get a chance to fix this spec
| runTests: false | ||
| working-directory: testing/regression/ | ||
|
|
||
| - name: Lint |
There was a problem hiding this comment.
do we want to format too... 😈 (for another PR for sure)
There was a problem hiding this comment.
(nit, b): given it takes a while to build all the docker and these two steps are fast, I think we should move them to the beginning so if this fails it's as fast as possible
| submitNewTab() { | ||
| var opener = {}; | ||
| opener.isUniqueElementName = this.isUniqueElementName; | ||
| opener.isUniqueElementName = true; |
There was a problem hiding this comment.
q: shouldn't opener.isUniqueElementName be a function which returns true?
The old value of opener.isUniqueElementName was the function this.isUniqueElementName which returns true but it has been changed to the value true.
|
|
||
| Then("User will see the following by {string} {string} {string}", (content, type, description) => { | ||
| manageSectionPage.seeElementOnManageSection(content, type, description); | ||
| Then("User will see the following by {string} {string} {string}", (content, type) => { |
There was a problem hiding this comment.
q: is the third {string} needed here since you've reduced the function call params to two?
It looks like all three are still used in e2e/features/edit-page/manageSection.feature so maybe put the third function param as _ or remove the third value in the .feature file altogether.
| import { faker } from "@faker-js/faker"; | ||
|
|
||
| When("I Generate HL7 messages to api and mark as review", (string) => { | ||
| When("I Generate HL7 messages to api and mark as review", () => { |
There was a problem hiding this comment.
q: is this When statement used anywhere? Searching locally only shows its definition.
| import UtilityFunctions from "@pages/utilityFunctions.page"; | ||
|
|
||
| When("I Seed HL7 {string} messages to api", (string) => { | ||
| When("I Seed HL7 {string} messages to api", () => { |
There was a problem hiding this comment.
q: is this When statement used anywhere? Searching locally only shows its definition.
mcmcgrath13
left a comment
mcmcgrath13
left a comment
There was a problem hiding this comment.
couple things to change on the CI, but overall a nice QoL improvement!
adaball
left a comment
adaball
left a comment
There was a problem hiding this comment.
A few minor comments but LGTM
Co-authored-by: Mary McGrath <m.c.mcgrath13@gmail.com>
3 participants
Description
no-unnecessary-waitingto a warning so that it will pass CI and we can re-enable once fixing these broken specsTickets
Checklist before requesting a review