Skip to content

APP 188 patient file morbidity report management - #3552

Merged
krista-skylight merged 21 commits into
mainfrom
kc/APP-188-Patient-File-Morbidity-Report-Management
Aug 12, 2026
Merged

APP 188 patient file morbidity report management#3552
krista-skylight merged 21 commits into
mainfrom
kc/APP-188-Patient-File-Morbidity-Report-Management

Conversation

@krista-skylight

@krista-skylight krista-skylight commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Description

e2e tests of patient field morbidity report management

Tickets

Checklist before requesting a review

  • PR focuses on a single story
  • Code has been fully tested to meet acceptance criteria
  • PR is reasonably small and reviewable (Generally less than 10 files and 500 changed lines)
  • All new functions/classes/components reasonably small
  • Functions/classes/components focused on one responsibility
  • Code easy to understand and modify (clarity over concise/clever)
  • PRs containing TypeScript follow the Do's and Don'ts
  • PR does not contain hardcoded values (Uses constants)
  • All code is covered by unit or feature tests

@krista-skylight krista-skylight changed the title Kc/app 188 patient file morbidity report management APP 188 patient file morbidity report management Aug 5, 2026
@krista-skylight
krista-skylight marked this pull request as ready for review August 7, 2026 22:59
@krista-skylight
krista-skylight requested a review from a team as a code owner August 7, 2026 22:59
@krista-skylight
krista-skylight requested review from adaball and mcmcgrath13 and removed request for a team August 7, 2026 22:59
And I click the Submit button
And user clicks the "View File" link, the user is returned to Patient profile summary page
And Click Events tab on Patient Profile Page
Then the "Investigations" count should increase by 1 in the Events tab

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(q, nb): should the morbidity report count also increase by 1?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't part of the written scenario but I could definitely add it as an extra check

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added here!

And I click on the Code Lookup button
And I select "No" from the Pregnant dropdown menu
And I click the Submit and Create Investigation button
And I click the Submit button

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(sugg, nb): should we check anything about the investigation page? (is that where we are?)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we are at the patient profile page where it shows a count of how many investigations there are. I didn't think there was anything we need to check about the investigation page, but lmk if you have ideas!

}

clickAddTreatment() {
cy.get(this.addTreatmentButton).click();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(sugg/q, nb): for the simpler interactions would we be able to use generic instructions (from generic.steps.js) instead of expanding the steps/page specific rules here? I know this is a change in approach for these features/pages, so feel free to disregard

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, I don't think these are generic enough for anything in generic.steps.js. The selectors are annoyingly not always uniquely identifiable via name or id and the roles are not consistent enough.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah well - a kid could dream

@mcmcgrath13 mcmcgrath13 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🔬

@adaball adaball left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@krista-skylight
krista-skylight merged commit 2f7c15f into main Aug 12, 2026
1 check passed
@krista-skylight
krista-skylight deleted the kc/APP-188-Patient-File-Morbidity-Report-Management branch August 12, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants