fix(clients): wait for connection before accepting commands - #2740
Merged
bmorcelli merged 1 commit intoAug 2, 2026
Merged
Conversation
Show a "Connecting..." message and block command input until the SSH or Telnet worker reports the session as ready or closed. A failed connection or login is now surfaced right away instead of after the user has already typed one or more commands.
0Zane
pushed a commit
to 0Zane/firmware
that referenced
this pull request
Aug 3, 2026
…ices#2740) Show a "Connecting..." message and block command input until the SSH or Telnet worker reports the session as ready or closed. A failed connection or login is now surfaced right away instead of after the user has already typed one or more commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Show a "Connecting..." message and block command input until the SSH or Telnet worker reports the session as ready or closed. Before this change the terminal opened right away as if connected, so a failed connection or a wrong login was only shown after the user had already typed one or more commands, and what they typed was lost.
The wait runs before the input loop in runSessionUiLoop, which is shared by SSH and Telnet, so both get the same behavior. You can still cancel with the back button while it is connecting.
Types of Changes
Enhancement.
Verification
Tested on a LilyGo T-Embed CC1101 Plus against both a Linux host and a Windows 11 host with OpenSSH.
Testing
This was verified manually on hardware. Compiles across all board envs.
Linked Issues
Closes #2739
User-Facing Change
Further Comments
The "Connecting..." message uses displayTextLine so it follows the active theme, like the other status messages in the UI.