Fix AUTC integration on NumPy < 2.0#269
Merged
Merged
Conversation
panoptica_result.py used np.trapezoid, which only exists in NumPy >= 2.0, while the project declares numpy>=1.22. Resolve np.trapezoid / np.trapz at import so Area-Under-Threshold-Curve works across the whole supported NumPy range. Without this, the AUTC and statistics tests fail on NumPy 1.x. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Area-Under-Threshold-Curve (AUTC) integration compatibility across the project’s declared NumPy support range (numpy>=1.22) by avoiding direct use of np.trapezoid (NumPy 2.0+ only) and falling back to np.trapz on NumPy 1.x.
Changes:
- Add a module-level
_trapezoidalias that resolves tonp.trapezoidwhen available, otherwisenp.trapz. - Update AUTC integration to call the resolved
_trapezoidfunction instead ofnp.trapezoiddirectly.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
LGTM, do not think we need that big of a comment tho |
ErikGro
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
panoptica_result.py used np.trapezoid, which only exists in NumPy >= 2.0, while the project declares numpy>=1.22. Resolve np.trapezoid / np.trapz at import so Area-Under-Threshold-Curve works across the whole supported NumPy range. Without this, the AUTC and statistics tests fail on NumPy 1.x.