Skip to content

feat(Dom2Image): update SnapDOM to v3.6.0 - #1263

Merged
ArgoZhang merged 2 commits into
masterfrom
dev-dom2image
Oct 29, 2026
Merged

ArgoZhang merged 2 commits into
masterfrom
dev-dom2image

Conversation

@Tony-ST0754

@Tony-ST0754 Tony-ST0754 commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Link issues

fixes #1262

Summary By Copilot

Update bundled SnapDOM from v3.5.0 to the official v3.6.0 npm release.

Regression?

  • Yes
  • No

Browser regression testing has not been run.

Risk

  • High
  • Medium
  • Low

Only the upstream bundle changes; existing wrapper APIs and asset path are preserved.

Verification

  • Manual (required)

  • Automated

  • node --check 'src\components\BootstrapBlazor.Dom2Image\wwwroot\lib\snapdom.mjs' — passed.

  • node --input-type=module -e "import { pathToFileURL } from 'node:url'; const { snapdom } = await import(pathToFileURL(process.argv[1])); if (typeof snapdom !== 'function') throw new Error('Missing snapdom export'); console.log('snapdom export: OK');" 'C:\Users\Argo\src\BootstrapBlazor.Extensions\src\components\BootstrapBlazor.Dom2Image\wwwroot\lib\snapdom.mjs' — passed.

  • git diff --check — passed.

  • SHA-256 comparison against the extracted official npm bundle — matched.

Browser capture tests and .NET tests were not run; this change replaces only the upstream JavaScript bundle.

Packaging changes reviewed?

  • Yes
  • No
  • N/A

The existing static asset path and MIT license header are preserved; no package metadata changes.

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Update Dom2Image to use SnapDOM v3.6.0 while preserving the existing integration and static asset path.

New Features:

  • Update the bundled SnapDOM library to the official v3.6.0 release.

Build:

  • Update the Dom2Image project dependency reference for SnapDOM v3.6.0.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@bb-auto

bb-auto Bot commented Oct 29, 2026

Copy link
Copy Markdown

Thanks for your PR, @Tony-ST0754. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@sourcery-ai

sourcery-ai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the bundled SnapDOM dependency to the official v3.6.0 release through a focused generated-bundle replacement, with existing asset paths and integration APIs unchanged. Automated validation confirms syntax, exports, formatting, and upstream bundle integrity; browser and .NET tests were not run.

File-Level Changes

Change Details Files
Replace the vendored SnapDOM implementation with the official v3.6.0 npm bundle while retaining the existing integration surface.
  • Update generated SnapDOM bundle content from v3.5.0 to v3.6.0.
  • Preserve the existing static asset path, wrapper APIs, and MIT license header.
  • Verify syntax, module export availability, formatting, and byte-for-byte parity with the official npm bundle.
src/components/BootstrapBlazor.Dom2Image/wwwroot/lib/snapdom.mjs

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto
bb-auto Bot requested a review from ArgoZhang October 29, 2026 01:20
@bb-auto bb-auto Bot added the enhancement New feature or request label Oct 29, 2026
@bb-auto bb-auto Bot added this to the v10.0.0 milestone Oct 29, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Fixed security issues:

  • Cross-site scripting (XSS) via untrusted HTML/JS injection in web rendering sinks (link)

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@ArgoZhang
ArgoZhang merged commit 57186eb into master Oct 29, 2026
3 checks passed
@ArgoZhang
ArgoZhang deleted the dev-dom2image branch October 29, 2026 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(Dom2Image): update SnapDOM to v3.6.0

2 participants