Conversation
There was a problem hiding this comment.
Sorry @ArgoZhang, your pull request is larger than the review limit of 150000 diff characters
Reviewer's GuideUpdates the embedded SnapDOM library to v2.24.0 and aligns the Blazor Dom2Image integration (options, service API, and JS glue) with the new SnapDOM features, including font embedding, caching, clipping, and download behavior fixes. Sequence diagram for updated getStream SnapDOM integrationsequenceDiagram
participant C# as Dom2ImageService
participant JS as dom2image.js
participant Snap as snapdom
C#->>JS: getStream(selector, options)
JS->>JS: document.querySelector(selector)
JS->>Snap: snapdom(el, options || {})
Snap-->>JS: result (snapdom capture object)
JS->>Snap: result.toBlob()
Snap-->>JS: Blob
JS-->>C#: Blob
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #1093
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Update the embedded SnapDOM library to v2.24.0 and expand the Dom2Image options and service API to support richer font handling, output configuration, and improved DOM capture behavior.
New Features:
Enhancements: