Skip to content

feat: funding address#98

Open
jackstar12 wants to merge 1 commit into
mainfrom
feat/funding-address
Open

feat: funding address#98
jackstar12 wants to merge 1 commit into
mainfrom
feat/funding-address

Conversation

@jackstar12
Copy link
Copy Markdown
Member

@jackstar12 jackstar12 commented Mar 3, 2026

Summary by CodeRabbit

  • New Features

    • Enabled routing for funding service requests so the app can handle /v2/funding operations.
  • Chores

    • Added funding-related configuration for timeout and buffer values to improve reliability and reduce failures during funding flows.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6f978048-2d0a-4636-ac7f-ca9678885325

📥 Commits

Reviewing files that changed from the base of the PR and between 6bfda4a and 268735c.

📒 Files selected for processing (2)
  • data/backend-nginx/default.conf
  • data/backend/boltz.conf
✅ Files skipped from review due to trivial changes (2)
  • data/backend-nginx/default.conf
  • data/backend/boltz.conf

📝 Walkthrough

Walkthrough

Adds an Nginx location routing ^/v2/funding proxying to the boltzr upstream and introduces a new [funding] section in data/backend/boltz.conf with timeoutDelta = 14400 and swapTimeoutBuffer = 10.

Changes

Cohort / File(s) Summary
Funding routing & config
data/backend-nginx/default.conf, data/backend/boltz.conf
Added nginx location ~ ^/v2/funding { proxy_pass http://boltzr; }. Added [funding] section with timeoutDelta = 14400 and swapTimeoutBuffer = 10.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Nginx
    participant Boltzr

    Client->>Nginx: HTTP request to /v2/funding
    Nginx->>Boltzr: proxy_pass http://boltzr (forward request)
    Boltzr-->>Nginx: response
    Nginx-->>Client: proxied response
Loading

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 I hopped a route from client to bolt,
Through nginx halls I made a vault,
Timeouts snug in rows aligned,
Swap buffers set, the path defined,
A tiny hop, the funding's kind.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'feat: funding address' is vague and does not clearly convey what changes were made. The actual changes add Nginx routing and configuration settings for a funding feature, but the title lacks specificity about the nature of the modifications. Consider a more descriptive title such as 'feat: add funding request routing and configuration' to better reflect that this adds both Nginx location routing and configuration settings.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/funding-address

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
data/backend/boltz.conf (1)

29-32: Minor formatting inconsistency.

The new [funding] section omits spaces around =, while the rest of the file uses spaces (e.g., host = "boltz"). Consider aligning for consistency.

 [funding]
-timeoutDelta=500
-swapTimeoutBuffer=10
+timeoutDelta = 500
+swapTimeoutBuffer = 10
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@data/backend/boltz.conf` around lines 29 - 32, The [funding] section has
inconsistent spacing around the equals sign; update the keys timeoutDelta and
swapTimeoutBuffer in the [funding] block to use spaces like the rest of the file
(e.g., timeoutDelta = 500 and swapTimeoutBuffer = 10) so formatting matches
other entries such as host = "boltz".
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@data/backend/boltz.conf`:
- Around line 29-32: The [funding] section has inconsistent spacing around the
equals sign; update the keys timeoutDelta and swapTimeoutBuffer in the [funding]
block to use spaces like the rest of the file (e.g., timeoutDelta = 500 and
swapTimeoutBuffer = 10) so formatting matches other entries such as host =
"boltz".

ℹ️ Review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c904c4d and 806d8cd.

📒 Files selected for processing (2)
  • data/backend-nginx/default.conf
  • data/backend/boltz.conf

@michael1011
Copy link
Copy Markdown
Member

Depends on BoltzExchange/boltz-backend#1164

@jackstar12 jackstar12 force-pushed the feat/funding-address branch from 806d8cd to 6bfda4a Compare March 8, 2026 20:55
@jackstar12 jackstar12 force-pushed the feat/funding-address branch from 6bfda4a to 268735c Compare March 23, 2026 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants