Skip to content

New Crowdin updates#7417

Merged
JohnThomson merged 1 commit intomasterfrom
l10n_master
Feb 16, 2026
Merged

New Crowdin updates#7417
JohnThomson merged 1 commit intomasterfrom
l10n_master

Conversation

@CrowdinBot
Copy link
Collaborator

@CrowdinBot CrowdinBot commented Oct 1, 2025

This change is Reviewable


Open with Devin

@coderabbitai
Copy link

coderabbitai bot commented Nov 7, 2025

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch l10n_master

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Copy link

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 new potential issues.

View 5 additional findings in Devin Review.

Open in Devin Review

<trans-unit id="templates.install_directory_custom" approved="yes">
<source xml:lang="en">The install directory is '&lt;A HREF="na"&gt;{path}&lt;/A&gt;'</source>
<target xml:lang="fr" state="needs-translation">The install directory is '&lt;A HREF="na"&gt;{path}&lt;/A&gt;'</target>
<target xml:lang="fr" state="final">Le répertoire d'installation est '&lt;A HREF="na"&gt;{path}\&lt;/A&gt;'</target>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 French velopack translation introduces extra backslash in install directory path

The French translation for templates.install_directory_custom adds an extra backslash \ after {path} that is not present in the English source string.

Source: ...&lt;A HREF="na"&gt;{path}&lt;/A&gt;...
French target: ...&lt;A HREF="na"&gt;{path}\&lt;/A&gt;...

This trailing backslash will be visible to French-speaking users in the install directory display, showing something like C:\Users\name\AppData\Local\BloomDesktop\ with an extraneous trailing backslash inside the hyperlink text. This was introduced by the translator and likely unintentional.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Comment on lines +189 to +190
<source xml:lang="en">{app_title} was successfully uninstalled.</source>
<target xml:lang="es-ES" state="translated">La aplicación se desinstaló correctamente.</target>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Spanish and French velopack uninstall message drops {app_title} placeholder

The source string for dialogs.uninstall_success.content was changed from The application was successfully uninstalled. to {app_title} was successfully uninstalled. to include the app name. However, both the Spanish and French translations don't use the {app_title} placeholder:

  • Spanish: La aplicación se desinstaló correctamente. (uses generic "The application")
  • French: L'application a été désinstallée avec succès. (uses generic "The application")

This means Spanish and French users will see a generic message instead of the app-specific one with the app name. While this is a Crowdin translation quality issue rather than a code bug, it defeats the purpose of the source string change. See also DistFiles/localization/fr/velopack.xlf:190.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@JohnThomson JohnThomson merged commit f523591 into master Feb 16, 2026
1 check passed
@JohnThomson JohnThomson deleted the l10n_master branch February 16, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants