Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| <trans-unit id="templates.install_directory_custom" approved="yes"> | ||
| <source xml:lang="en">The install directory is '<A HREF="na">{path}</A>'</source> | ||
| <target xml:lang="fr" state="needs-translation">The install directory is '<A HREF="na">{path}</A>'</target> | ||
| <target xml:lang="fr" state="final">Le répertoire d'installation est '<A HREF="na">{path}\</A>'</target> |
There was a problem hiding this comment.
🚩 French velopack translation introduces extra backslash in install directory path
The French translation for templates.install_directory_custom adds an extra backslash \ after {path} that is not present in the English source string.
Source: ...<A HREF="na">{path}</A>...
French target: ...<A HREF="na">{path}\</A>...
This trailing backslash will be visible to French-speaking users in the install directory display, showing something like C:\Users\name\AppData\Local\BloomDesktop\ with an extraneous trailing backslash inside the hyperlink text. This was introduced by the translator and likely unintentional.
Was this helpful? React with 👍 or 👎 to provide feedback.
| <source xml:lang="en">{app_title} was successfully uninstalled.</source> | ||
| <target xml:lang="es-ES" state="translated">La aplicación se desinstaló correctamente.</target> |
There was a problem hiding this comment.
🚩 Spanish and French velopack uninstall message drops {app_title} placeholder
The source string for dialogs.uninstall_success.content was changed from The application was successfully uninstalled. to {app_title} was successfully uninstalled. to include the app name. However, both the Spanish and French translations don't use the {app_title} placeholder:
- Spanish:
La aplicación se desinstaló correctamente.(uses generic "The application") - French:
L'application a été désinstallée avec succès.(uses generic "The application")
This means Spanish and French users will see a generic message instead of the app-specific one with the app name. While this is a Crowdin translation quality issue rather than a code bug, it defeats the purpose of the source string change. See also DistFiles/localization/fr/velopack.xlf:190.
Was this helpful? React with 👍 or 👎 to provide feedback.
ddd4dca to
bf75b8c
Compare
This change is