Skip to content

Redis migration#11

Merged
GoodrichDev merged 5 commits intomainfrom
redis-migration
Apr 3, 2026
Merged

Redis migration#11
GoodrichDev merged 5 commits intomainfrom
redis-migration

Conversation

@GoodrichDev
Copy link
Copy Markdown
Member

No description provided.

Completely removes plugin channel messaging paths and proxy relay modules due to security risk.

- Remove Bungee and Velocity bridge modules from the build and delete their source trees.

- Delete Bukkit/Core plugin-channel listener and sync/backlog handler classes.

- Enforce Redis-only sync type with automatic migration from unsupported values.

- Add authenticated sync payload validation via Data.Sync.Security.Token.

- Require non-default token configuration before accepting cross-server sync traffic.

- Update defaults/docs to Redis + required shared secret.
Document removal of plugin-channel messaging, Redis-only transport, token validation, and related migration/fix notes.
- Add redis-authx-core dependency so shaded jars include Token class required by Jedis 7 pub/sub.

- Include redis.clients.authentication artifacts in platform shade filters.

- Guard Redis runtime init when auth classes are missing, disabling sync instead of crashing startup.

- Prevent disable-time NPE when storage failed to initialize.
Use plugin/class/resource loader candidates when checking for redis-auth Token classes so Folia/Paper do not disable Redis sync due to context-classloader misses.
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 05a456b514

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread pom.xml
Comment on lines 15 to 19
<module>PaperCore</module>
<module>Folia</module>
<module>Sponge8</module>
<module>Bungee</module>
<module>Velocity</module>
<module>Currency Templates</module>
<module>TestCore</module>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep a listener for tne:message before removing proxy bridges

Removing the Bungee/Velocity modules here leaves MessageHandler.send() with no working cross-server transport. I checked TheNewPluginCore's core/io/redis/TNEJedisManager, and the Redis subscriber still subscribes only to tne:balance; it never receives the tne:message channel that Core/src/net/tnemc/core/channel/MessageHandler.java publishes. After this change, commands like /money give can still update balances, but players on other servers will silently stop receiving the remote notification/message payloads.

Useful? React with 👍 / 👎.

@GoodrichDev GoodrichDev merged commit ad551c6 into main Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant