fix: test cases for parseWithdrawPsbt #7750
Open
+640
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OttoAllmendinger
requested changes
Dec 16, 2025
Comment on lines
22
to
28
| /** | ||
| * Creates a random PSBT for testing purposes with customizable options. | ||
| * This helper function generates a PSBT with a fake input and configurable outputs. | ||
| * | ||
| * @param options - Configuration options for PSBT creation | ||
| * @returns A constructed PSBT instance and the master key used | ||
| */ |
Contributor
There was a problem hiding this comment.
we don't really want "random", it can lead to flaky tests
that being said, you are not using a lot of randomness anyway (just the keys)
rename to createTestPsbt and use fixed keys instead
you can get an ECPair instance with utxolib.bip32.fromSeed(...).privateKey
this makes the output deterministic which use good for testing
parvbitgo067
force-pushed
the
BTC-2545-fix-test-cases
branch
from
c139a64 to
83af8e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TICKET: BTC-2545