feat(sdk-coin-near): address verification for near #7712
+138
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpkjnr
reviewed
Dec 12, 2025
dpkjnr
reviewed
Dec 17, 2025
Comment on lines
+1007
to
+1017
| const { address, rootAddress } = params; | ||
|
|
||
| // Root address verification requires index 0 | ||
| const isVerifyingRootAddress = rootAddress && address === rootAddress; | ||
| if (isVerifyingRootAddress) { | ||
| const index = typeof params.index === 'string' ? parseInt(params.index, 10) : params.index; | ||
| if (index !== 0) { | ||
| throw new Error(`Root address verification requires index 0, but got index ${params.index}.`); | ||
| } | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
lets avoid these, keep implementation very simple, similar to Sol
dpkjnr
reviewed
Dec 17, 2025
Comment on lines
+1024
to
+1028
| if (!result) { | ||
| throw new UnexpectedAddressError(`address validation failure: address ${params.address} is not a wallet address`); | ||
| } | ||
|
|
||
| return true; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
isWalletAddressfornearto cryptographically verify that an address belongs to a TSS/MPC wallet usingHD verification