Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
fail-fast: false
matrix:
php: [ "8.1", "8.2", "8.3" ]
symfony: ["^5.4", "^6.4"]
symfony: [ "^6.4" ]
sylius: [ "~1.13.0", "~1.14.0" ]
node: [ "18.x", "20.x" ]
mysql: ["8.0"]
Expand All @@ -40,7 +40,7 @@ jobs:

steps:
-
uses: actions/checkout@v3
uses: actions/checkout@v4

-
name: Setup PHP
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/coding_standard.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
fail-fast: false
matrix:
php: [ "8.1", "8.2", "8.3" ]
symfony: [ "^5.4", "^6.4" ]
symfony: [ "^6.4" ]
sylius: [ "^1.13", "^1.14" ]
node: [ "18.x", "20.x" ]

Expand Down
2 changes: 2 additions & 0 deletions spec/CommandHandler/Wishlist/CreateNewWishlistHandlerSpec.php
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ public function it_creates_new_wishlist_for_user(
$tokenUserResolver->resolve($token)->willReturn($shopUser);

$wishlistCookieTokenResolver->resolve()->willReturn('token');
$wishlistCookieTokenResolver->new()->willReturn('token');
$wishlistFactory->createForUser($shopUser)->willReturn($wishlist);

$wishlist->getShopUser()->willReturn($shopUser);
Expand Down Expand Up @@ -141,6 +142,7 @@ public function it_doesnt_add_duplicated_wishlist_name_for_user(
$tokenUserResolver->resolve($token)->willReturn($shopUser);

$wishlistCookieTokenResolver->resolve()->willReturn('token');
$wishlistCookieTokenResolver->new()->willReturn('token');
$wishlistFactory->createForUser($shopUser)->willReturn($wishlist);

$wishlist->getShopUser()->willReturn($shopUser);
Expand Down
6 changes: 5 additions & 1 deletion src/CommandHandler/Wishlist/CreateNewWishlistHandler.php
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,11 @@ public function __invoke(CreateNewWishlist $createNewWishlist): int
}

if ('' !== $wishlistCookieToken) {
$wishlist->setToken($wishlistCookieToken);
if ($user instanceof ShopUserInterface) {
$wishlist->setToken($this->wishlistCookieTokenResolver->new());
} else {
$wishlist->setToken($wishlistCookieToken);
}
}

if (null !== $createNewWishlist->getChannelCode()) {
Expand Down
5 changes: 5 additions & 0 deletions src/Resolver/WishlistCookieTokenResolver.php
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,9 @@ public function resolve(): string

return (string) new WishlistToken();
}

public function new(): string
{
return (string) new WishlistToken();
}
}
2 changes: 2 additions & 0 deletions src/Resolver/WishlistCookieTokenResolverInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,6 @@
interface WishlistCookieTokenResolverInterface
{
public function resolve(): string;

public function new(): string;
}
Loading