适配windows - #1
Conversation
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…omebrew Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…ints Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…issing Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…anagement Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
适配windows |
|
首先,感谢你提交 echolog 的第一个外部 PR —— 一上来就啃 Windows 适配这块硬骨头,很有勇气也很有价值 🙌。能看出来背后做了认真的设计(plan/spec 都写了),整体方向是对的。 我通读了一遍,先说最亮的地方: 下面是一些建议。核心一句话:这个 PR 其实把两件事捆在了一起 —— 一类是低风险的跨平台修复(很棒,建议尽快进),另一类是「把 CLI 整体重写成 Node + pm2 + 降级依赖」(这个动到了项目根基,建议先对齐再做)。如果能拆成两个 PR,第一类我这边可以很快帮你 review 合并。 ✅ 建议拆出来、可以马上进的部分
这部分纯增益、不破坏任何现有体验,单独成 PR 我直接合。
|
|
补充一条 👇 我把「Windows 支持」整理成了一个可认领的任务追踪 issue:#2 —— 把你这个 PR 里的工作按风险拆成了 A/B/C/D/E/F 几组,低风险的跨平台修复(findBin、去硬编码、HOME 兼容、安装提示)列在 🟢 A 组,可以拆出来快速合;进程管理那块放在 🟡 B 组、建议先在 issue 下对齐方案再动手。 后来想参与的朋友也能照着 #2 按块认领,不用从零理。你这个 PR 是整件事的种子,辛苦了 🙏。建议你从 🟢 A 组挑一两项先拆成小 PR,我这边尽快帮你 review + 合。 —— 老一 (laoyi@zhidun.ai) |
…ix Windows edges - Replace pm2 with child_process.spawn(detached) + PID file model - Revert undici ^7.8.0 → ^8.2.0, engines >=20 → >=22 (cloud LLM chain) - Remove pm2 dependency from package.json - Fix process.env.HOME → HOME || USERPROFILE in doctor.js (Windows crash) - Uncouple doctor.js + recover-missing.js from pm2 - Add windowsHide: true to spawn/execFile calls (suppress console popups) - Fix cmdRestart race: poll for old process exit before starting new one - Restore Chinese comments (symlink resolution, --noproxy rationale) - Bilingual help text (Chinese/English) - Delete superpowers plan/spec drafts (~1110 lines) - README: note Windows voice transcription not yet supported Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
- CLAUDE.md: update CLI description (bash → Node.js), cross-platform dependency install hints (brew / winget / whisper.cpp releases) - README.md: Windows install/run guidance, bash setup script caveat - README.zh-CN.md: voice transcription platform note, CLI usage for Windows Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
refactor: address PR #1 review — remove pm2, fix Windows edges, update docs
What & why
Briefly describe the change and the motivation.
Checklist
.env/ personal data / real names / tokens / user IDs / open_ids committed (example configs stay generic)node --checksyntax check passes on touchedindex-*.js/lib/*.jsbash tests/run-all.sh, ornode tests/*.test.js)README.md/docs/)Notes for reviewers