Skip to content

Click events for SVG Elements#229

Draft
i-mitra wants to merge 2 commits into
BigBadaboom:masterfrom
criodigital:master
Draft

Click events for SVG Elements#229
i-mitra wants to merge 2 commits into
BigBadaboom:masterfrom
criodigital:master

Conversation

@i-mitra

@i-mitra i-mitra commented Jul 19, 2021

Copy link
Copy Markdown

Hey Paul,

Before I go ahead and added more flexibilities and features for click events, I thought I'd review with you some of the changes on SVG and SVGBase.

  • SVGBase
    I added couple of methods for us to fetch all elements at a specific location, which can be restricted to only elements with ids. We could move containsCoords into Box as it's more of a helper method for Box.
  • SVG
    Just exposing getElementsAt from base.
  • SVGRenderer
    Rather than fetching for ids, I thought we might as well put them in idToElementMap while creating the render tree. We could change this to getIdToElementMap().put(id, obj). Moreover we can then expose getIdToElementMap().

Let me know what you think.

Ishan

@i-mitra i-mitra marked this pull request as draft July 19, 2021 12:07
@BigBadaboom

Copy link
Copy Markdown
Owner

Thanks. This looks useful. I'll look through the code as soon as I have a bit of time, and add some comments.

@debugnrebuild

debugnrebuild commented Oct 5, 2022

Copy link
Copy Markdown

any update on this Merge Request ?

@BigBadaboom BigBadaboom removed a link to an issue Apr 2, 2023
@asadaltaf583

Copy link
Copy Markdown

I want to interact with svg layers ie i want to add as many sticker views as layers in svg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants