feat(shared): add full-address tooltip to CopyAddress - #418
Merged
Conversation
- Add SystemHealthCard component with real-time health indicators - Add useSystemHealth hook for polling health status - Add health checkers library (lib/health/checkers.ts) - Add health types (lib/types/health.ts) - Add /api/admin/health route handler - Integrate SystemHealthCard into admin overview page - Add SystemHealthCard unit tests
- Create components/ui/tooltip.tsx — thin @base-ui/react Tooltip wrapper matching the project's Popover wrapper style (Provider/Root/Trigger/Content) - Update CopyAddress: wrap trigger in Tooltip so the full address is revealed on hover and keyboard focus for both the default and showIconOnly variants - Add aria-label="Wallet address: <full>" to both variants for screen readers - Add keyboard handler (Enter/Space) on the default variant's div trigger - Remove old generic title attributes; tooltip now carries the address content - Add __tests__/CopyAddress.test.tsx with 16 tests covering: truncation display, tooltip content, aria-label, clipboard copy (success & failure), keyboard activation, showIconOnly variant, and truncate=false path
|
@Deyanju23 is attempting to deploy a commit to the therealjhay's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Deyanju23 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #299
Summary
Improve the
CopyAddresscomponent by exposing the full wallet address via a tooltip while preserving the existing truncated display and copy functionality.Problem
The component currently displays truncated addresses (e.g.,
GBX...4Q3), making it impossible for users to verify the full address without copying it. This also limits accessibility for keyboard and screen reader users.Solution
titleattribute) displaying the full address.aria-labelcontaining the full address.Implementation Details
Component
Updated:
components/shared/CopyAddress.tsxChanges include:
titleattribute.aria-labelwith the complete address.Accessibility
aria-label.Testing Checklist
aria-labelexposes the complete address.Screenshots
N/A (Small UI enhancement)