Repository navigation
Backport a ReversePatch fix from upstream - #134
Merged
ManlyMarco merged 1 commit intoSep 8, 2025
Merged
Conversation
Upstream changed to not use ThreadStatic, but to instead use a lock which fixes an issue where ReversePatches could disappear. The rebase to 2.3.6 didn't pulled it because it implied other changes that didn't fit with HarmonyX, but the underlying fix should still be applied when it wasn't.
ManlyMarco
approved these changes
Sep 8, 2025
This was referenced Dec 1, 2025
This was referenced Feb 15, 2026
This was referenced Apr 20, 2026
This was referenced Jul 28, 2026
This was referenced Aug 6, 2026
This was referenced Aug 20, 2026
This was referenced Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream changed to not use ThreadStatic, but to instead use a lock which fixes an issue where ReversePatches could disappear. The rebase to 2.3.6 didn't pulled it because it implied other changes that didn't fit with HarmonyX, but the underlying fix should still be applied when it wasn't.