Skip to content

Item group filter#225

Open
nibkind wants to merge 19 commits into
mainfrom
item-group-filter
Open

Item group filter#225
nibkind wants to merge 19 commits into
mainfrom
item-group-filter

Conversation

@nibkind

@nibkind nibkind commented Mar 24, 2026

Copy link
Copy Markdown
Collaborator

Claude wrote this so please check it for problems, I don't have a way to test it

This pull request is meant to add the item group filter, so that the Item Tag field is always available

Currently, can only get item group by following the link from an existing pet craving, and it only works in the market.

Changes should allow:
-Customizing the Item Tag search field in the basement, if you start typing it should autocomplete existing item group
-Navigating directly to URL like /basement?filter.itemGroup=Fresh%20Fruit should pre-apply the item group filter

nibkind added 4 commits March 23, 2026 19:39
Add encyclopedia endpoint for item group names
Adds a new /encyclopedia/item-groups API endpoint returning all item group names. Hopefully adds autocomplete for item group tag
Adds a text input with native browser autocomplete to the item search dialog for filtering by item group. Suggestions are fetched from the new /encyclopedia/item-groups endpoint and narrow as the user types.
Support filter.itemGroup query param in basement URL
@nibkind nibkind requested a review from BenMakesGames as a code owner March 24, 2026 06:19
removing trailing `s
@BenMakesGames

Copy link
Copy Markdown
Owner

oooooooh - I'm excited! thanks for trying this out!

I am getting several warnings & errors; I'm sure if you tell Claude something like "I'm getting some build errors & warnings on item-search.dialog.ts - can you check, and fix them?" it will know how.

image

@nibkind

nibkind commented Mar 24, 2026

Copy link
Copy Markdown
Collaborator Author

Claude also suggested removing some imports, but then immediately was like wait no we need that
image

@BenMakesGames

Copy link
Copy Markdown
Owner

@nibkind interesting! I'll look into it more closely!

@BenMakesGames

BenMakesGames commented Mar 24, 2026

Copy link
Copy Markdown
Owner

looks like my local environment was just confused; I'm unable to reproduce the warning. sorry about the false alarm!

with the errors & warnings gone, I was able to test the feature out, aaaaand: it's not working as written, I believe for two reasons:

1. the tag isn't being applied after clicking "search":

testing item group filter in basement

2. when putting the tag name in the URL, the tag IS applied in the front-end, and it IS sent to the back-end (API), but the filtering doesn't happen :(

image

to try:

I think point 2 will be the easier to fix: either the filter isn't passed quite right, or the basement search endpoint doesn't support filtering by item tag. either way, you should be able to ask Claude to look into it and fix it.

for fixing point 1, ask Claude to find the existing tag typeahead component - that will probably get it most of the way there, and hopefully far enough that it can figure out anything else that may be wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants