Adding more network features for scripts. #709
Open
Toys0125 wants to merge 5 commits intoBasisVR:developerfrom
Open
Adding more network features for scripts. #709Toys0125 wants to merge 5 commits intoBasisVR:developerfrom
Toys0125 wants to merge 5 commits intoBasisVR:developerfrom
Conversation
Had to do this as we can not assume Id=0 means no owner as we start at id 0 for first user.
Contributor
Author
|
Other option is when we release the owner we set |
Collaborator
|
We really should just have a trygetownershipid that gives you back false or true, done that a few places in the code base. I like using zero as the starting point as well, that's programming |
Contributor
Author
Okay added the TryGetOwnerId in which checks if we have it cached, and outputs the owner id, otherwise returns false. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For instance the server normally sends a remove owner and set the ID=0. Which works for everyone, except the first person. We start the player Id at 0. Which breaks this assumption with single player or low player count servers. So went and added a simple bool that the NetworkContent class will track if there is an owner assigned.