Skip to content

fix(desktop): conversation title edit hits nonexistent endpoint, never saves #7484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
the-scott-davis wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −7
Open

fix(desktop): conversation title edit hits nonexistent endpoint, never saves #7484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2753a40
fix(desktop): title edit hits correct backend endpoint
the-scott-davis May 24, 2026
1c6c8c0
desktop: changelog - conversation title edit fix
the-scott-davis May 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion desktop/CHANGELOG.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
{
"unreleased": [],
"unreleased": [
"Fixed editing a conversation title not saving"
],
"releases": [
{
"version": "0.11.421",
Expand Down
9 changes: 3 additions & 6 deletions desktop/Desktop/Sources/APIClient.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,15 +369,12 @@ extension APIClient {

/// Updates the title of a conversation
func updateConversationTitle(id: String, title: String) async throws {
struct TitleUpdate: Encodable {
let title: String
}

let url = URL(string: baseURL + "v1/conversations/\(id)")!
var components = URLComponents(string: baseURL + "v1/conversations/\(id)/title")!
components.queryItems = [URLQueryItem(name: "title", value: title)]
let url = components.url!
var request = URLRequest(url: url)
request.httpMethod = "PATCH"
request.allHTTPHeaderFields = try await buildHeaders(requireAuth: true)
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot May 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Content-Type: application/json on a body-less PATCH

buildHeaders always injects "Content-Type": "application/json", but this request no longer sends a body. Sending Content-Type: application/json with an empty body is technically incorrect and could confuse proxies or strict middleware. This pattern is already widespread in APIClient.swift (e.g., the starred PATCH on line 327), so it's a pre-existing issue not introduced here, but worth noting while the endpoint contract is being corrected.

request.httpBody = try JSONEncoder().encode(TitleUpdate(title: title))

let (_, response) = try await session.data(for: request)
guard let httpResponse = response as? HTTPURLResponse,
Expand Down