-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix(app): voice response no longer cut off by notification chime (#7135) #7180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+65
−26
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4e09678
fix(app): keep voice response alive across notifications
mdmohsin7 11dd033
fix(app): suppress FCM foreground notification while voice is speaking
mdmohsin7 49a4dcd
fix(app): reset _pausedByInterruption in _clearInFlightState
mdmohsin7 0bd1eb6
fix(app): voice response stops working after the first question
mdmohsin7 8424fe0
chore(app): log audio-session interruption events for diagnosis
mdmohsin7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_player.play()in theend+pausebranch is unawaited and has no error handling. If_clearInFlightState()was called between the begin and end events (or the player is in an idle/error state because the audio source was swapped), the call can throw an unhandled exception that silently disappears as an unawaitedFuture. Wrapping it in a try/catch keeps the handler robust.