Skip to content

fix avoid context access after widget disposal #4112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
krushnarout wants to merge 5 commits into
base: main
Choose a base branch
from
+32 −21
Open

fix avoid context access after widget disposal #4112

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
58cb1a5
fix avoid context access after widget disposal
krushnarout Jan 7, 2026
18da5c5
extract providers
krushnarout Jan 7, 2026
ec7451a
remove extra mounted check
krushnarout Jan 11, 2026
ee3d53c
remove mounted check
krushnarout Jan 11, 2026
7008d00
format
krushnarout Jan 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 32 additions & 21 deletions app/lib/core/app_shell.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,17 +55,17 @@ class _AppShellState extends State<AppShell> {
}

if (uri.pathSegments.first == 'apps') {
if (mounted) {
var app = await context.read<AppProvider>().getAppFromId(uri.pathSegments[1]);
if (app != null) {
PlatformManager.instance.mixpanel.track('App Opened From DeepLink', properties: {'appId': app.id});
if (mounted) {
Navigator.of(context).push(MaterialPageRoute(builder: (context) => AppDetailPage(app: app)));
}
} else {
debugPrint('App not found: ${uri.pathSegments[1]}');
AppSnackbar.showSnackbarError('Oops! Looks like the app you are looking for is not available.');
}
final appProvider = context.read<AppProvider>();
final app = await appProvider.getAppFromId(uri.pathSegments[1]);

if (!mounted) return;

if (app != null) {
PlatformManager.instance.mixpanel.track('App Opened From DeepLink', properties: {'appId': app.id});
Navigator.of(context).push(MaterialPageRoute(builder: (context) => AppDetailPage(app: app)));
} else {
debugPrint('App not found: ${uri.pathSegments[1]}');
AppSnackbar.showSnackbarError('Oops! Looks like the app you are looking for is not available.');
}
} else if (uri.pathSegments.first == 'wrapped') {
if (mounted) {
Expand Down Expand Up @@ -364,23 +364,34 @@ class _AppShellState extends State<AppShell> {
initDeepLinks();

WidgetsBinding.instance.addPostFrameCallback((_) async {
if (context.read<AuthenticationProvider>().isSignedIn()) {
context.read<HomeProvider>().setupHasSpeakerProfile();
context.read<HomeProvider>().setupUserPrimaryLanguage();
context.read<UserProvider>().initialize();
context.read<PeopleProvider>().initialize();
final auth = context.read<AuthenticationProvider>();

if (auth.isSignedIn()) {
final homeProvider = context.read<HomeProvider>();
final userProvider = context.read<UserProvider>();
final peopleProvider = context.read<PeopleProvider>();
homeProvider.setupHasSpeakerProfile();
homeProvider.setupUserPrimaryLanguage();
userProvider.initialize();
peopleProvider.initialize();
try {
await PlatformManager.instance.intercom.loginIdentifiedUser(SharedPreferencesUtil().uid);
} catch (e) {
debugPrint('Failed to login to Intercom: $e');
}

context.read<MessageProvider>().setMessagesFromCache();
context.read<AppProvider>().setAppsFromCache();
context.read<MessageProvider>().refreshMessages();
context.read<UsageProvider>().fetchSubscription();
context.read<TaskIntegrationProvider>().loadFromBackend();
if (!mounted) return;

final messageProvider = context.read<MessageProvider>();
final appProvider = context.read<AppProvider>();
final usageProvider = context.read<UsageProvider>();
final taskIntegrationProvider = context.read<TaskIntegrationProvider>();

messageProvider.setMessagesFromCache();
appProvider.setAppsFromCache();
messageProvider.refreshMessages();
usageProvider.fetchSubscription();
taskIntegrationProvider.loadFromBackend();
NotificationService.instance.saveNotificationToken();
} else {
if (!PlatformManager.instance.isAnalyticsSupported) {
Expand Down