BE: user password recovery#30
Open
walczyk123 wants to merge 6 commits into
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| end | ||
|
|
||
| def reset_password(user) | ||
| if user.update(password: @password, password_confirmation: @password_confirmation, reset_password_token: nil, reset_password_sent_at: nil) |
Check failure
Code scanning / CodeQL
Clear-text storage of sensitive information
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 1 year ago
To fix the problem, we need to ensure that the passwords are encrypted before being stored in the database. The best way to achieve this is by using a well-known library like bcrypt to hash the passwords. This will ensure that even if the database is compromised, the passwords are not stored in plain text and are thus protected.
- Install the
bcryptgem if it is not already installed. - Modify the
reset_passwordmethod to hash the passwords before storing them in the database.
Suggested changeset
1
backend/app/services/reset_password_service.rb
| @@ -1 +1,3 @@ | ||
| require 'bcrypt' | ||
|
|
||
| class ResetPasswordService < BaseService | ||
| @@ -32,3 +34,5 @@ | ||
| def reset_password(user) | ||
| if user.update(password: @password, password_confirmation: @password_confirmation, reset_password_token: nil, reset_password_sent_at: nil) | ||
| hashed_password = BCrypt::Password.create(@password) | ||
| hashed_password_confirmation = BCrypt::Password.create(@password_confirmation) | ||
| if user.update(password: hashed_password, password_confirmation: hashed_password_confirmation, reset_password_token: nil, reset_password_sent_at: nil) | ||
| :success |
Copilot is powered by AI and may make mistakes. Always verify output.
Barcol
reviewed
Mar 27, 2025
Barcol
reviewed
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes