Open
Conversation
JohnCox2211
requested changes
Mar 18, 2026
Contributor
JohnCox2211
left a comment
There was a problem hiding this comment.
Upon a quick lookover, I noticed there is a duplicate function
| display: none; | ||
| } | ||
|
|
||
| #sidebar-toggle svg { |
Contributor
|
There is an additional issue with the modal for the labor history page for the student's labor forms appearing too large when opened and a lot of it hangs off of the screen |
Contributor
|
Encountered an issue with the overload acceptance page when clicking the new sidebar button. The button popped to the middle of the screen and dimmed the screen as if the sidebar had opened, but it did not appear. When expanding the size of the screen, the new sidebar completely disappeared and did not reappear with a refresh. |
Arohasina
requested changes
Mar 18, 2026
| $('body').removeClass('sidebar-is-open'); | ||
| $('#sidebar-toggle').attr('aria-expanded', false); | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #372
Issue Description: The page that students use to record their overload reason is terrible on phones. See if there is a way to fix that without worrying about fixing all of LSF.
Issue Fixed:
sidebar.html: Created a hamburger UI button when the side bar collapsed
sidebar.js: Created functions for sidebar to expand and collapse.
sidebar.css: Created media-queries and transition for the sidebar to be responsive
Issue potential question:
Why am I not using bootstrap?
Bootstrap in LSF is outdated and if bootstrap CDN is used the whole LSF design changed and messed up the UI. Which is why media-queries are used for sidebar.
Why made the sidebar responsive when the issue description is about fixing overload responsiveness?
As per the picture we can see if we allow side bar to be collapsible we made not just the overload page but the whole feature responsive as the sidebar in a fixed position causes the UI to not be responsive.
When sidebar collapsed in mobile width:

When sidebar expanded in a mobile width:

Testing:
git checkout sidebarResponsivegit pullflask run