-
Notifications
You must be signed in to change notification settings - Fork 14
Labor attendance report 1626 #1684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Arohasina
wants to merge
15
commits into
development
Choose a base branch
from
Labor_Attendance_report_1626
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
5905549
added the function laborAttendanceByTerm
Arohasina 97fe183
added test function test_laborAttendanceByTerm
Arohasina 4c89d93
added laborAttendanceByTerm to the spreadsheet
Arohasina be0b9af
removed print statements
Arohasina eeb4674
removed commented code
Arohasina 07e2ded
Update app/logic/volunteerSpreadsheet.py
Arohasina ee86729
Update app/logic/volunteerSpreadsheet.py
Arohasina c9119da
Merge branch 'development' of https://github.com/BCStudentSoftwareDev…
JohnCox2211 6209cba
removed redundant event and reused existing ones
Arohasina d68bda6
Merge branch 'Labor_Attendance_report_1626' of github.com:BCStudentSo…
Arohasina 4a863e3
added distinct
Arohasina 7652303
Merge remote-tracking branch 'origin' into Labor_Attendance_report_1626
Arohasina d37e2ae
include all labor students even with zero attendance and non-labor at…
Arohasina 7936d62
added the return
Arohasina 86fd8c6
Merge remote-tracking branch 'origin' into Labor_Attendance_report_1626
Arohasina File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -32,7 +32,8 @@ def fixture_info(): | |
| startDate=date(2023, 9, 1), | ||
| isCanceled=False, | ||
| deletionDate=None, | ||
| isService=True | ||
| isService=True, | ||
| isLaborOnly=True | ||
| ) | ||
| event2 = Event.create( | ||
| name='Event2', | ||
|
|
@@ -41,7 +42,8 @@ def fixture_info(): | |
| startDate=date(2023, 9, 10), | ||
| isCanceled=False, | ||
| deletionDate=None, | ||
| isService=True | ||
| isService=True, | ||
| isLaborOnly=True | ||
|
Comment on lines
+45
to
+46
|
||
| ) | ||
| event3 = Event.create( | ||
| name='Event3', | ||
|
|
@@ -683,5 +685,16 @@ def test_getUniqueVolunteers(fixture_info): | |
| ("Test Tester", "testt@berea.edu", "B55555"), | ||
| ]) | ||
|
|
||
|
|
||
|
|
||
| @pytest.mark.integration | ||
| def test_laborAttendanceByTerm(fixture_info): | ||
| EventParticipant.create(event=fixture_info["event2"], user=fixture_info['user1'], hoursEarned=1) | ||
| EventParticipant.create(event=fixture_info["event2"], user=fixture_info['user2'], hoursEarned=1) | ||
| EventParticipant.create(event=fixture_info["event1"], user=fixture_info['user3'], hoursEarned=1) | ||
|
|
||
| columns, results = laborAttendanceByTerm("2023-2024-test") | ||
| assert columns == ("Full Name", "B-Number", "Email", "Term", "Meetings Attended") | ||
|
|
||
| assert len(results) == 3 | ||
| assert ("John Doe", "B774377", "doej@berea.edu", "Fall 2023", 2) in results | ||
| assert ("Jane Doe", "B888828", "doej2@berea.edu", "Fall 2023", 2) in results | ||
| assert ("Bob Builder", "B00700932", "builderb@berea.edu", "Fall 2023", 1) in results | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is trailing whitespace after the comma on these lines. Consider removing it for consistency with the rest of the codebase.