Listener code - #52
Merged
Merged
Conversation
TomekFraczek
approved these changes
Mar 6, 2026
TomekFraczek
left a comment
TomekFraczek
left a comment
Member
There was a problem hiding this comment.
This looks really good. I think it's basically ready to merge
Comment on lines
+67
to
+77
| if args.mode == 'listen': | ||
| try: | ||
| parser.listen() | ||
| except AttributeError: | ||
| parser.error( | ||
| f"Parser '{parser.__class__.__name__}' does not support listen mode. " | ||
| f"Ensure your config uses listener mixins, not checker mixins." | ||
| ) | ||
| except Exception as e: | ||
| parser.error(f"Listen mode failed: {e}", exc_info=True) | ||
| else: |
Member
There was a problem hiding this comment.
Is this not redundant with the listen.py script?
Collaborator
Author
There was a problem hiding this comment.
Yes agreed, I have refactored argument parser in run.py and now run.py handles only checker mode and listen.py listener mode
| event['timestamp'] = now | ||
|
|
||
| current_state = self.load_state() | ||
| for key in ['success', 'failure', 'skipped']: |
Member
There was a problem hiding this comment.
I think I'd just make it loop through all the keys, so you don't have to care which states exist
Collaborator
Author
There was a problem hiding this comment.
Yes, updated the code accordingly
…r mode and listen.py listener mode
… events more efficiently
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.