Generalised private endpoint module - #407
Open
abatallas wants to merge 4 commits into
Open
Conversation
abatallas
requested review from
bwatrous,
David Watrous (dpwatrous) and
ryanhamel
and
a balanced review from Copilot
September 3, 2026 21:28
There was a problem hiding this comment.
🟡 Changes recommended
The new module invocation fails validation, and the MySQL DNS zone is incorrect for AzureCloud.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Generalizes private endpoint and DNS provisioning for Blob Storage and MySQL.
Changes:
- Extracts reusable private endpoint, DNS zone, and VNet-link modules.
- Moves storage networking out of the storage module.
- Generalizes private DNS zone types.
File summaries
| File | Description |
|---|---|
bicep/vnetLink.bicep |
Adds reusable VNet linking. |
bicep/types.bicep |
Generalizes DNS zone types. |
bicep/storage.bicep |
Removes networking and exports storage ID. |
bicep/storage-vnetLink.bicep |
Removes storage-specific linking. |
bicep/storage-newDnsZone.bicep |
Removes storage-specific DNS creation. |
bicep/privateEndpoint.bicep |
Adds generalized endpoint orchestration. |
bicep/privateDnsZone.bicep |
Adds reusable DNS zone creation. |
bicep/mainTemplate.bicep |
Uses the generalized DNS type. |
bicep/ccw.bicep |
Wires storage into the new endpoint module. |
Review details
- Files reviewed: 9/9 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
abatallas
force-pushed
the
abatallas/private_endpoint_module
branch
from
September 4, 2026 16:49
c1ca722 to
656d787
Compare
There was a problem hiding this comment.
🟡 Changes recommended
Existing-zone handling, sovereign-cloud DNS names, and resource-specific tags are currently incorrect.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 9/9 changed files
- Comments generated: 3
- Review effort level: Balanced
abatallas
force-pushed
the
abatallas/private_endpoint_module
branch
from
September 4, 2026 18:11
656d787 to
aaa4f7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates a set of files to create a private endpoint for either storage or MySQL and removes those files specific to storage accounts.