Restore cluster name field - #395
Merged
Merged
Conversation
abatallas
requested review from
bwatrous,
Copilot,
ryanhamel and
Xavier Pillons (xpillons)
July 20, 2026 20:46
There was a problem hiding this comment.
Pull request overview
This PR restores an explicit Cluster name input in the Azure Create UI Definition and aligns cluster-name character handling across the UI and deployment template logic.
Changes:
- Reintroduced a visible
clusterNametextbox increateUiDefinition.jsonwith updated validation rules and messages. - Added pytest coverage to ensure the UI’s
clusterNameregex validations accept/reject expected values. - Updated Bicep cluster-name sanitization to remove
_from the accepted character set and coerce invalid characters to-.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| uidefinitions/createUiDefinition.json | Restores and validates a visible clusterName field; updates VM name tooltip text. |
| tests/test_create_ui_regexes.py | Adds tests that load and enforce the clusterName regex validations from the UI definition JSON. |
| bicep/ccw.bicep | Adjusts cluster-name sanitization (accepted characters and replacement behavior) and outputs the sanitized value. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
abatallas
force-pushed
the
abatallas/restore_cluster_name_field
branch
from
July 23, 2026 19:07
a089f29 to
ac0aad8
Compare
ryanhamel
approved these changes
Jul 23, 2026
bwatrous
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.