Fix duplicate errors for undefined types on resources#19273
Open
brendandburns wants to merge 7 commits intoAzure:mainfrom
Open
Fix duplicate errors for undefined types on resources#19273brendandburns wants to merge 7 commits intoAzure:mainfrom
brendandburns wants to merge 7 commits intoAzure:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Missing_resource_type_in_resource_declaration_emits_only_first_type_diagnosticIssue
Fixes #5025
Key Changes
src/Bicep.Core/TypeSystem/DeclaredTypeManager.csGetDeclaredResourceType(ResourceDeclarationSyntax resource)whenresource.Type.IsSkippedsrc/Bicep.Core.UnitTests/Semantics/ResourceDeclarationDiagnosticTests.csBCP068is emitted forresource trailingSpaceValidation
dotnet test src/Bicep.Core.UnitTests/Bicep.Core.UnitTests.csproj --filter "FullyQualifiedName~ResourceDeclarationDiagnosticTests"dotnet format --verify-no-changesdotnet format style --diagnostics IDE0005 --severity info --verify-no-changesMicrosoft Reviewers: Open in CodeFlow