Add Functions Timer trigger templates for Python, JavaScript, TypeScript, PowerShell, and Java#844
Add Functions Timer trigger templates for Python, JavaScript, TypeScript, PowerShell, and Java#844Copilot wants to merge 2 commits into
Conversation
…Shell, and Java Agent-Logs-Url: https://github.com/Azure/awesome-azd/sessions/4fb013cc-3fa6-438b-9fed-a4ebbc3ba0c0 Co-authored-by: hemarina <104857065+hemarina@users.noreply.github.com>
hemarina
requested review from
JeffreyCA,
jongio,
kristenwomack,
rajeshkamal5050,
vhvb1989,
wbreza and
weikanglim
as code owners
There was a problem hiding this comment.
Pull request overview
Adds the remaining Azure Functions Timer trigger quickstart templates to the Awesome AZD gallery, aligning with the existing Azure Functions quickstart pattern and enabling discovery across multiple languages.
Changes:
- Added 5 new Azure Functions Timer trigger template entries (Python, JavaScript, TypeScript, PowerShell, Java).
- Tagged templates as Microsoft-authored with Flex Consumption deployment-related Azure service tags and Bicep IaC.
| "title": "Azure Functions Python Timer Trigger using Azure Developer CLI", | ||
| "description": "This repository contains an Azure Functions Timer trigger quickstart written in Python and deployed to Azure Functions Flex Consumption using the Azure Developer CLI (azd). The sample uses managed identity and a virtual network to make sure deployment is secure by default.", | ||
| "preview": "./templates/images/test.png", | ||
| "authorUrl": "https://github.com/Azure-Samples", | ||
| "author": "Azure Functions Team", | ||
| "source": "https://github.com/Azure-Samples/functions-quickstart-python-azd-timer", |
There was a problem hiding this comment.
These entries are tagged as Microsoft-authored ("msft"). Per the repo’s template review guidelines, please include a link to a test pipeline run or other proof (e.g., screenshots/logs) showing that each of these templates successfully deploys with azd up.
There was a problem hiding this comment.
@im-samz Could you provide proof of test run for these templates?
There was a problem hiding this comment.
@hemarina Sure. We will start testing these templates today.
There was a problem hiding this comment.
@hemarina, @im-samz We have finished this template test, and we filed six issues. Please review.
- README prerequisites are missing Docker requirement for running Azurite locally Azure-Samples/functions-quickstart-python-azd-timer#2
- VS Code debug/task configuration uses an incorrect working directory Azure-Samples/functions-quickstart-python-azd-timer#3
- README VS Code run/debug steps are incomplete Azure-Samples/functions-quickstart-javascript-azd-timer#2
- Unable to run
func startsuccessfully according to the README Azure-Samples/functions-quickstart-java-azd-timer#2 - Failed to Run
func startin Codespaces Azure-Samples/functions-quickstart-powershell-azd-timer#3 AzuriteExtension Not Installed in Codespaces Environment Azure-Samples/functions-quickstart-powershell-azd-timer#4
jongio
left a comment
jongio
left a comment
There was a problem hiding this comment.
5 timer-trigger templates following the existing .NET pattern. Tag validation passes (all defined in tags.tsx, correct placement), all source repos exist and are public, UUIDs are unique, tests pass (336/336).
Two items before this can merge:
- Merge conflicts - this PR conflicts with main and needs a rebase.
- Deployment proof - these are msft-tagged templates. @hemarina can you provide a test pipeline link or screenshots showing each template deploys successfully with
azd up?
Minor: the descriptions say "make sure deployment is secure by default" and reference "azd" (lowercase), while the existing .NET timer template uses "ensure it's secure by default" and "AZD" (uppercase). Not blocking, but worth aligning for consistency.
|
Thanks for this! Timer trigger across all 5 supported languages in a single PR is exactly the bundling pattern we want — gives Functions devs a complete language matrix in one gallery update. Two asks before merge:
|
|
Friendly nudge — this PR has been idle since 4/28 and now has an active merge conflict against Two items remain blocking before merge:
Also (non-blocking, from @jongio's earlier review): consider aligning the descriptions with the existing .NET Timer entry — Repo-standards checks all pass on the current diff: tag placement is correct, PowerShell is in |
kristenwomack
left a comment
kristenwomack
left a comment
There was a problem hiding this comment.
Thanks @v-xuto for running these through manual test and filing the 6 issues, that's exactly the validation this PR needed. And thanks @hemarina for coordinating the handoff after @im-samz moved off Functions.
Reading through the filed issues, I don't think we should merge yet. A quick triage:
- Blocking: java/issues/2 —
func startfails per the README. That breaks the quickstart story we're shipping into the gallery, so the Java template shouldn't land until that's resolved. - Should fix before merge: the two PowerShell Codespaces issues (#3, #4). "Try it in Codespaces" is a primary CTA in the gallery; if Codespaces is broken, the discovery experience is broken.
- Nice to fix, not blocking: the three README gaps (Python prereqs, Python VS Code working dir, JavaScript run/debug steps). Could merge with these as fast-follow if the above two are resolved.
A couple of options to keep this moving:
- Split the PR — merge Python / JavaScript / TypeScript now (with the README fixes as fast-follows on those repos), and hold Java + PowerShell until their blockers clear.
- Hold the whole PR until the Java and PowerShell blockers are fixed and v-xuto re-verifies, then merge as one set.
@hemarina, do you have a preference? Either way, also still pending: the rebase against main, and Jon's earlier nit about description consistency with the existing .NET Timer entry ("ensure it's secure by default" and AZD uppercase).
Follow-up to #839 — adds the remaining Azure Functions Timer trigger quickstart templates across all supported languages.
Templates added to
templates.jsonfunctions-quickstart-python-azd-timerfunctions-quickstart-javascript-azd-timerfunctions-quickstart-typescript-azd-timerfunctions-quickstart-powershell-azd-timerfunctions-quickstart-java-azd-timerAll entries follow the existing .NET timer template pattern: Microsoft-authored, Flex Consumption deployment, Bicep IaC, with
functions,managedidentity,vnets, andappinsightsas Azure services. PowerShell usespowershellintags(notlanguages) consistent with other PowerShell templates since it's defined astype: "Tools"intags.tsx.