fix(ingestor): retry with backoff management commands on 429 and >=500 errors#896
Open
matucker-msft wants to merge 1 commit intomainfrom
Open
fix(ingestor): retry with backoff management commands on 429 and >=500 errors#896matucker-msft wants to merge 1 commit intomainfrom
matucker-msft wants to merge 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements automatic retry logic with exponential backoff for Kusto management commands in the ADX ingestor. The primary purpose is to improve reliability when interacting with Azure Data Explorer by handling transient failures gracefully.
- Adds a new retry mechanism that handles HTTP 429 (throttling), 5xx server errors, and other transient Kusto SDK errors
- Wraps all existing Kusto management operations with retry logic using exponential backoff
- Uses Kubernetes wait utilities for consistent backoff behavior with configurable parameters
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| ingestor/adx/retry.go | New file implementing retry logic with exponential backoff for Kusto management commands |
| ingestor/adx/uploader.go | Wraps cluster details query with retry mechanism |
| ingestor/adx/syncer.go | Wraps all management operations (table creation, mapping, functions, policies) with retry logic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.