FEAT: More Informative Attack Exceptions #1318
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has something that has bugged me for a while, but I hadn't thought of a good solution for it. I think the solution here is decent, and it definitely improves usability. And I don't want perfect to get in the way of good...
Old way
The exceptions take some digging and often don't help.
e.g. here is a retry for a target. Which target? You'll never know...
Now, here is an error in objective_target, not that you would know that either....
New way
It still takes wrapping critical pieces in a handler, but I think it's already quite good. And will improve as we update identifiers to be better.
Here is a new error in objective_scorer:
Here is an error in a converter
Similar errors are available for both adversarial and objective chats. Here are new retry messages which now contain the component