Draft
Conversation
ludamad
force-pushed
the
ad/refactor/reduce-ci-duplication
branch
2 times, most recently
from
6adbdf3 to
3bd6f02
Compare
ci.sh: - network_ec2(): dispatches network commands to EC2, consolidating CI_DASHBOARD/INSTANCE_POSTFIX/CPUS/bootstrap_ec2 boilerplate - setup_denoise_run(): sets DENOISE env and defines the run() function used by grind, merge-queue, merge-queue-heavy, and release bootstrap.sh: - bench_upload(): replaces 4 identical bench merge+upload blocks - resolve_docker_image(): builds and pushes image to aztecdev if none provided, used by the three network deploy/bench cases
ludamad
force-pushed
the
ad/refactor/reduce-ci-duplication
branch
from
3bd6f02 to
7dd14c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidates duplicate code across ci.sh endpoints by extracting common patterns into reusable utilities and helper functions. Proposes multiple approaches to reduce code duplication while maintaining clarity and maintainability. This refactoring decreases the maintenance burden and makes future CI changes easier to implement consistently.