Open
Conversation
ludamad
approved these changes
Feb 13, 2026
AztecBot
force-pushed
the
cl/all_in_makefile
branch
from
6689aad to
9935512
Compare
charlielye
added
ci-full
AztecBot
force-pushed
the
cl/all_in_makefile
branch
from
9716e35 to
77533db
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
AztecBot
force-pushed
the
cl/all_in_makefile
branch
from
cece801 to
e2749c6
Compare
AztecBot
force-pushed
the
cl/all_in_makefile
branch
from
e2749c6 to
89c3816
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
AztecBot
force-pushed
the
cl/all_in_makefile
branch
from
06504aa to
ad04453
Compare
Let's just commit to the makefile and deal with issues. * Uses process substitution in denoises redact. Think this fixes some edge case where redact lingers and prevents denoise exiting. * `npm_deploy` mutates packages in a tmp copy to prevent clobbering tests underfoot. * bootstrap builds are now all makefile driven. Get rid of `-makefile` commands. * Put job counts on parallel call in ci.sh as using nproc is too low. Weak machines can spin up many strong machines. * Adds NUMA awareness to benchmarks. If CPU's requested is < cores per NUMA node, we wait until we can get all the CPU's on a single node, else we fallback to old behaviour and just grab whatever cores we can. This is probably satisfactory as higher core count benches are generally a different longer running category of benches.
AztecBot
force-pushed
the
cl/all_in_makefile
branch
from
ad04453 to
daf7a7e
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 23, 2026
Let's just commit to the makefile and deal with issues. * Uses process substitution in denoises redact. Think this fixes some edge case where redact lingers and prevents denoise exiting. * `npm_deploy` mutates packages in a tmp copy to prevent clobbering tests underfoot. * bootstrap builds are now all makefile driven. Get rid of `-makefile` commands. * Put job counts on parallel call in ci.sh as using nproc is too low. Weak machines can spin up many strong machines. * Adds NUMA awareness to benchmarks. If CPU's requested is < cores per NUMA node, we wait until we can get all the CPU's on a single node, else we fallback to old behaviour and just grab whatever cores we can. This is probably satisfactory as higher core count benches are generally a different longer running category of benches.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's just commit to the makefile and deal with issues.
npm_deploymutates packages in a tmp copy to prevent clobbering tests underfoot.-makefilecommands.