fix: don't flag "more orange than red" etc.#2928
Merged
elijah-potter merged 7 commits intoAutomattic:masterfrom Mar 24, 2026
Merged
fix: don't flag "more orange than red" etc.#2928elijah-potter merged 7 commits intoAutomattic:masterfrom
elijah-potter merged 7 commits intoAutomattic:masterfrom
Conversation
86xsk
reviewed
Mar 16, 2026
…re-subtle-than-direct-2925
…re-subtle-than-direct-2925
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Apr 9, 2026
⚠️ **CAUTION: this is a major update, indicating a breaking change!**⚠️ This MR contains the following updates: | Package | Update | Change | |---|---|---| | [Automattic/harper/harper-ls](https://github.com/Automattic/harper) | major | `v1.12.0` → `v2.0.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>Automattic/harper (Automattic/harper/harper-ls)</summary> ### [`v2.0.0`](https://github.com/Automattic/harper/releases/tag/v2.0.0) [Compare Source](Automattic/harper@v1.12.0...v2.0.0) #### What's Changed Hey all! We're finally releasing Harper 2.0. Why? It isn't because we have any new groundbreaking features in this release, because we don't let major versioning stop us from pushing those out as soon as they're ready. It's because we have some breaking changes. The biggest one only applies to you if you consume `harper.js`. From now on, instead of importing your binary from the main Harper module, you'll import it from one of four specialized modules. Previously, you'd import the Harper WebAssembly binary with: ```javascript import { LocalLinter, binary } from "harper.js"; ``` As of Harper 2.0, you'll import it like this: ```javascript import { LocalLinter } from "harper.js"; import { binary } from "harper.js/binary"; ``` It's that simple! Thanks to this change, you'll find that your applications are more conducive to tree-shaking and therefore might even be a bit smaller! In addition to that large breaking change, we also have a bunch of smaller improvements rolling out. I won't go through them one by one, but you're free to read through any of the linked pull requests below. - refactor(core): use `Option::get_or_insert_with` by [@​86xsk](https://github.com/86xsk) in [#​2977](Automattic/harper#2977) - test(linting): add comprehensive test cases for were/where lint rule by [@​estefafdez](https://github.com/estefafdez) in [#​2984](Automattic/harper#2984) - feat: means a lot for→means a lot to by [@​hippietrail](https://github.com/hippietrail) in [#​2982](Automattic/harper#2982) - feat: add subcommand to generate shell completions by [@​deckstose](https://github.com/deckstose) in [#​2978](Automattic/harper#2978) - refactor(core): extract indefinite article logic into its own module by [@​mvanhorn](https://github.com/mvanhorn) in [#​2980](Automattic/harper#2980) - feat(web): auto-detect dark theme from OS preference in [#​2963](Automattic/harper#2963) - build(deps): bump tar from 0.4.44 to 0.4.45 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2986](Automattic/harper#2986) - feat: as evident by -> as evidenced by by [@​mvanhorn](https://github.com/mvanhorn) in [#​2985](Automattic/harper#2985) - fix(core): `SplitWords` allowing uncommon merges by [@​elijah-potter](https://github.com/elijah-potter) in [#​2874](Automattic/harper#2874) - feat: add lint rule for flaunt/flout mix-up in [#​2962](Automattic/harper#2962) - test: add regression tests for need\_to\_noun false positives ([#​2320](Automattic/harper#2320)) by [@​majiayu000](https://github.com/majiayu000) in [#​3014](Automattic/harper#3014) - fix: case-insensitive same-form check in SimplePastToPastParticiple by [@​saschabuehrle](https://github.com/saschabuehrle) in [#​3012](Automattic/harper#3012) - build(deps): bump pulldown-cmark from 0.13.1 to 0.13.3 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​3002](Automattic/harper#3002) - build(deps): bump tree-sitter-rust from 0.24.0 to 0.24.1 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​3003](Automattic/harper#3003) - build(deps): bump zip from 8.1.0 to 8.3.1 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​3000](Automattic/harper#3000) - build(deps): bump cached from 0.56.0 to 0.59.0 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​3001](Automattic/harper#3001) - chore(harper.js): update `raw-web` example to `1.12.0` by [@​elijah-potter](https://github.com/elijah-potter) in [#​3015](Automattic/harper#3015) - feat: "a" & "an" both OK for "URL" by [@​hippietrail](https://github.com/hippietrail) in [#​2981](Automattic/harper#2981) - feat: except of→except for / exception of by [@​hippietrail](https://github.com/hippietrail) in [#​2997](Automattic/harper#2997) - build(deps): bump rustls-webpki from 0.103.8 to 0.103.10 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2991](Automattic/harper#2991) - feat: aspire for → aspire to by [@​hippietrail](https://github.com/hippietrail) in [#​3004](Automattic/harper#3004) - docs: added link to agent policy by [@​elijah-potter](https://github.com/elijah-potter) in [#​3016](Automattic/harper#3016) - fix(lint-framework): reconnect popup host after DOM replacement by [@​k4sperski](https://github.com/k4sperski) in [#​2998](Automattic/harper#2998) - fix(harper-cli): return exit code 0 when no lints are found by [@​Ryujiyasu](https://github.com/Ryujiyasu) in [#​2836](Automattic/harper#2836) - chore: dictionary curation 2026-03-19 by [@​hippietrail](https://github.com/hippietrail) in [#​2968](Automattic/harper#2968) - Added native Neovim LSP config to docs by [@​RobertCrummett](https://github.com/RobertCrummett) in [#​2987](Automattic/harper#2987) - fix: don't flag "more orange than red" etc. by [@​hippietrail](https://github.com/hippietrail) in [#​2928](Automattic/harper#2928) - perf(core): cache `WordSet` in `ModalVerb` by [@​86xsk](https://github.com/86xsk) in [#​3017](Automattic/harper#3017) - feat: flag "use to" when "used to" is intended in [#​2975](Automattic/harper#2975) - feat: flag nonstandard "verse" used as a verb (from "versus") in [#​2973](Automattic/harper#2973) - feat: flag "date back from" as blend of "date from" and "date back to" in [#​2976](Automattic/harper#2976) - feat(core): allow users to include dictionaries in Weirpacks by [@​elijah-potter](https://github.com/elijah-potter) in [#​2922](Automattic/harper#2922) - feat: try out one's luck→try one's luck by [@​hippietrail](https://github.com/hippietrail) in [#​2916](Automattic/harper#2916) - fix(chrome-ext): reverse the toggle button to it appears "on" by [@​elijah-potter](https://github.com/elijah-potter) in [#​3026](Automattic/harper#3026) - chore: dictionary curation by [@​hippietrail](https://github.com/hippietrail) in [#​3023](Automattic/harper#3023) - Improve embedded form support in iframes by [@​k4sperski](https://github.com/k4sperski) in [#​3010](Automattic/harper#3010) - refactor: compact token/lint content & char comparison by [@​hippietrail](https://github.com/hippietrail) in [#​2957](Automattic/harper#2957) - feat: expression to match pronoun-be, word pair or contraction by [@​hippietrail](https://github.com/hippietrail) in [#​2944](Automattic/harper#2944) - fix(chrome-ext): persist lint rule changes from settings page by [@​queelius](https://github.com/queelius) in [#​3028](Automattic/harper#3028) - feat: in 1 day from now→in one day/one day from now by [@​hippietrail](https://github.com/hippietrail) in [#​3049](Automattic/harper#3049) - build(deps): bump tree-sitter-ink-lbz from 0.0.1 to 0.0.5 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​3064](Automattic/harper#3064) - build(deps): bump ordered-float from 5.1.0 to 5.3.0 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​3063](Automattic/harper#3063) - build(deps): bump zip from 8.3.1 to 8.4.0 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​3065](Automattic/harper#3065) - feat: support Quarto qmd files as markdown by [@​itamarst](https://github.com/itamarst) in [#​3053](Automattic/harper#3053) - feat: thrive off (of)→thrive on by [@​hippietrail](https://github.com/hippietrail) in [#​3055](Automattic/harper#3055) - perf(core): optimizations in `LintGroup` by [@​86xsk](https://github.com/86xsk) in [#​3052](Automattic/harper#3052) - feat: worth while/worth-while → worthwhile by [@​hippietrail](https://github.com/hippietrail) in [#​3056](Automattic/harper#3056) - refactor(core)!: `Lrc<[char]>` instead of `Lrc<Vec<char>>` by [@​86xsk](https://github.com/86xsk) in [#​3060](Automattic/harper#3060) - chore: dictionary curation by [@​hippietrail](https://github.com/hippietrail) in [#​3041](Automattic/harper#3041) - build(deps): bump tree-sitter-rust from 0.24.1 to 0.24.2 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​3061](Automattic/harper#3061) - fix(obsidian): OOM error by reducing WASM bundle size by [@​elijah-potter](https://github.com/elijah-potter) in [#​3050](Automattic/harper#3050) - build(deps): bump tree-sitter-scala from 0.24.0 to 0.25.0 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​3062](Automattic/harper#3062) - fix(lint): add 'side' to ignore list for effect/affect rule (fix issue [#​2958](Automattic/harper#2958)) by [@​estefafdez](https://github.com/estefafdez) in [#​2983](Automattic/harper#2983) - perf(spell): skip redundant lowercase DFA search in FstDictionary by [@​k4sperski](https://github.com/k4sperski) in [#​3025](Automattic/harper#3025) - refactor!: take argument by value instead of mut ref by [@​86xsk](https://github.com/86xsk) in [#​3051](Automattic/harper#3051) - feat: Sneaked vs snuck by [@​hippietrail](https://github.com/hippietrail) in [#​2209](Automattic/harper#2209) - feat: skeleton for new `ExprLinter` modules by [@​hippietrail](https://github.com/hippietrail) in [#​3024](Automattic/harper#3024) - feat: web scrapping → web scraping by [@​hippietrail](https://github.com/hippietrail) in [#​3059](Automattic/harper#3059) - fix: add key stroke→keystroke to key stoke→keystroke by [@​hippietrail](https://github.com/hippietrail) in [#​3067](Automattic/harper#3067) - perf(core): avoid conversion between string and char array by [@​86xsk](https://github.com/86xsk) in [#​3074](Automattic/harper#3074) - fix: don't flag "each of whom" by [@​hippietrail](https://github.com/hippietrail) in [#​3078](Automattic/harper#3078) - docs(web): add link to [@​KraXen72](https://github.com/KraXen72)'s work by [@​elijah-potter](https://github.com/elijah-potter) in [#​3079](Automattic/harper#3079) - feat: at all cost → at all costs by [@​hippietrail](https://github.com/hippietrail) in [#​3082](Automattic/harper#3082) - fix(core): address recent false positives and negatives by [@​elijah-potter](https://github.com/elijah-potter) in [#​3090](Automattic/harper#3090) - feat: add styling for user-defined monospace fonts by [@​stanley-910](https://github.com/stanley-910) in [#​3105](Automattic/harper#3105) - feat: I am bias/you are prejudice→biased/prejudiced by [@​hippietrail](https://github.com/hippietrail) in [#​3058](Automattic/harper#3058) - fix: don't flag "to" before "only" in ToTwoToo by [@​joaquinhuigomez](https://github.com/joaquinhuigomez) in [#​3093](Automattic/harper#3093) - feat: ppl→people by [@​hippietrail](https://github.com/hippietrail) in [#​3116](Automattic/harper#3116) - feat/obsidian web lint styling by [@​stanley-910](https://github.com/stanley-910) in [#​3104](Automattic/harper#3104) - fix(lint-framework): preserve cursor position when dismissing suggestion popup by [@​draphy](https://github.com/draphy) in [#​3112](Automattic/harper#3112) - build(deps): bump uuid from 1.22.0 to 1.23.0 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​3117](Automattic/harper#3117) - fix: skip PronounVerbAgreement for hyphenated compounds by [@​mvanhorn](https://github.com/mvanhorn) in [#​3095](Automattic/harper#3095) - fix(harper-tex): mask additional LaTeX math environments by [@​jurajkl](https://github.com/jurajkl) in [#​3103](Automattic/harper#3103) - feat: look forward for→look forward to by [@​hippietrail](https://github.com/hippietrail) in [#​3109](Automattic/harper#3109) - build(deps): bump tempfile from 3.20.0 to 3.27.0 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​3118](Automattic/harper#3118) - build(deps): bump indexmap from 2.13.0 to 2.13.1 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​3121](Automattic/harper#3121) - build(deps): bump tracing-subscriber from 0.3.22 to 0.3.23 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​3120](Automattic/harper#3120) - build(deps): bump zip from 8.4.0 to 8.5.0 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​3119](Automattic/harper#3119) - fix(core): exclude prepositions and conjunctions from QuiteQuiet pattern by [@​draphy](https://github.com/draphy) in [#​3127](Automattic/harper#3127) - feat: arrive to → arrive at/in by [@​hippietrail](https://github.com/hippietrail) in [#​3125](Automattic/harper#3125) - feat(core): create `UseEllipsisCharacter` rule by [@​elijah-potter](https://github.com/elijah-potter) in [#​3099](Automattic/harper#3099) - Fix indentation handling in harper-tex by [@​jurajkl](https://github.com/jurajkl) in [#​3106](Automattic/harper#3106) - feat: will ran → will run / ran by [@​hippietrail](https://github.com/hippietrail) in [#​2268](Automattic/harper#2268) - feat: in the best of times→at the best of times by [@​hippietrail](https://github.com/hippietrail) in [#​3133](Automattic/harper#3133) - feat: render configuration structurally by [@​elijah-potter](https://github.com/elijah-potter) in [#​3123](Automattic/harper#3123) - fix(chrome-ext): issues with Google Docs by [@​elijah-potter](https://github.com/elijah-potter) in [#​3141](Automattic/harper#3141) #### New Contributors - [@​estefafdez](https://github.com/estefafdez) made their first contribution in [#​2984](Automattic/harper#2984) - [@​deckstose](https://github.com/deckstose) made their first contribution in [#​2978](Automattic/harper#2978) - [@​mvanhorn](https://github.com/mvanhorn) made their first contribution in [#​2980](Automattic/harper#2980) - [@​majiayu000](https://github.com/majiayu000) made their first contribution in [#​3014](Automattic/harper#3014) - [@​saschabuehrle](https://github.com/saschabuehrle) made their first contribution in [#​3012](Automattic/harper#3012) - [@​k4sperski](https://github.com/k4sperski) made their first contribution in [#​2998](Automattic/harper#2998) - [@​Ryujiyasu](https://github.com/Ryujiyasu) made their first contribution in [#​2836](Automattic/harper#2836) - [@​RobertCrummett](https://github.com/RobertCrummett) made their first contribution in [#​2987](Automattic/harper#2987) - [@​queelius](https://github.com/queelius) made their first contribution in [#​3028](Automattic/harper#3028) - [@​itamarst](https://github.com/itamarst) made their first contribution in [#​3053](Automattic/harper#3053) - [@​joaquinhuigomez](https://github.com/joaquinhuigomez) made their first contribution in [#​3093](Automattic/harper#3093) - [@​jurajkl](https://github.com/jurajkl) made their first contribution in [#​3103](Automattic/harper#3103) **Full Changelog**: <Automattic/harper@v1.12.0...v2.0.0> </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xMDkuMyIsInVwZGF0ZWRJblZlciI6IjQzLjEwOS4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiLCJhdXRvbWF0aW9uOmJvdC1hdXRob3JlZCIsImRlcGVuZGVuY3ktdHlwZTo6bWFqb3IiXX0=-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #2925
Description
We were flag "more [adj]" in a context where it's part of a legitimate English construction: "more [adj] than [adj]".
How Has This Been Tested?
I added a unit test using the sentence in the GitHub issue.
Checklist