refactor(core): refactor TokenStringExt#2888
Merged
elijah-potter merged 1 commit intoAutomattic:masterfrom Apr 13, 2026
Merged
Conversation
Refactor `TokenStringExt` to provide default implementations for most of the trait's methods. This reduces the amount boilerplate needed to implement the trait.
elijah-potter
approved these changes
Apr 13, 2026
Collaborator
elijah-potter
left a comment
elijah-potter
left a comment
There was a problem hiding this comment.
Thank you! This was sorely needed.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Collaborator
|
It looks like GH Actions had an outage. I'm going to requeue this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor
TokenStringExtto provide default implementations for most of the trait's methods. This reduces the amount boilerplate needed to implement the trait.With the changes,
TokenStringExthas only 2 required methods:tokensandtokens_mut. The rest of the methods now have a default implementation that uses one of those 2 methods.I don't think this is a breaking change, since (IIUC) the
TokenStringExttrait is sealed, so it can't be implemented outside the crate. Not 100% sure though.How Has This Been Tested?
cargo testChecklist