Add shared test helper utilities (tests/helpers) - #202
Open
Armolas wants to merge 1 commit into
Open
Conversation
Consolidates duplicated mock-response/request builders, JWT test-token generation, mock TypeORM repository wiring, and success/error response assertions into tests/helpers, and refactors middleware.test.ts and WalletController.test.ts to use them as a proof of concept.
|
@Armolas Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidates duplicated mock-response/request builders, JWT test-token generation, mock TypeORM repository wiring, and success/error response assertions into tests/helpers, and refactors middleware.test.ts and WalletController.test.ts to use them as a proof of concept.
Description
Adds a shared
tests/helpers/module (auth.ts,db.ts,http.ts,assertions.ts,index.ts) so tests no longer duplicate the same boilerplate.setupTestDb()/teardownTestDb()wrap the existingjest.mock('AppDataSource')convention (no real Postgres test DB exists in this repo, and CI never spins one up) instead of standing up real infra, andcreateAuthenticatedRequest()is a mock request builder (no supertest) matching how every existing controller/middleware test already works.middleware.test.tsandWalletController.test.tsare refactored to use the new helpers as a proof of concept, andsrc/__tests__/testHelpers.test.tscovers every exported helper directly, including a round-trip through the realauthMiddleware.requireAuth.Fixes #120
Type of change
Checklist: