Skip to content

feat: add city bike illustrations and bonus star#400

Merged
Dahly96 merged 2 commits into
mainfrom
magnus/add-citybike-illustrations
Jun 11, 2026
Merged

feat: add city bike illustrations and bonus star#400
Dahly96 merged 2 commits into
mainfrom
magnus/add-citybike-illustrations

Conversation

@Dahly96

@Dahly96 Dahly96 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds new color illustrations to @atb-as/generate-assets.

Mobility (common/colors/images/mobility/, light + dark):

  • CityBikereplaces the previous CityBike with the new red manual bike (no person)
  • ElectricCityBike
  • CityBikeRide, ElectricCityBikeRide — person riding
  • CityBikeStation, ElectricCityBikeStation — bike at docking station
  • CityBikeStationPerson, ElectricCityBikeStationPerson — docking station with person
  • StartCityBike — hand pressing the handlebar button to start a trip

Bonus (atb/colors/images/bonus/, light + dark):

  • BonusStar (hand holding a star) — placed in atb as it is AtB-specific, with an empty width=0 height=0 fallback added to common for the other orgs, matching the existing bonus image pattern.

Test plan

  • Verify each illustration renders correctly in light and dark
  • Confirm CityBike replacement looks right where it's already used
  • Confirm non-AtB orgs fall back to the empty BonusStar

Add new mobility illustrations (light + dark) to common:
- CityBike (replaces previous), ElectricCityBike
- CityBikeRide, ElectricCityBikeRide
- CityBikeStation, ElectricCityBikeStation
- CityBikeStationPerson, ElectricCityBikeStationPerson
- StartCityBike

Add BonusStar to atb (atb-specific) with empty fallback in common
for other orgs, matching the existing bonus image pattern.
@Dahly96 Dahly96 self-assigned this Jun 10, 2026
The station illustrations carry the Trondheim bysykkel "eyes" logo, so
they are AtB-specific. Move CityBikeStation, ElectricCityBikeStation,
CityBikeStationPerson and ElectricCityBikeStationPerson (light + dark)
from common to atb, with empty fallbacks left in common for other orgs,
matching the BonusStar pattern.
@Dahly96 Dahly96 merged commit 4d30c4b into main Jun 11, 2026
@Dahly96 Dahly96 deleted the magnus/add-citybike-illustrations branch June 11, 2026 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants