feat: add affected stop places to situations - #469
Merged
Conversation
Extends the shared `situation` GraphQL fragment with `affects`, pulling stopPlace/quay names so clients can list affected stops on situation messages. Also updates favorites.ts to type its helpers against the local DeparturesQuery shape instead of casting to the upstream EstimatedCall, since the new SituationFragment shape tipped the cast into a type error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the shared
situationGraphQL fragment withaffects, pullingstopPlace/quay names so clients can list affected stops on situation
messages.
Also updates favorites.ts to type its helpers against the local
DeparturesQuery shape instead of casting to the upstream EstimatedCall,
since the new SituationFragment shape tipped the cast into a type error.